Update go version to 1.11.2 for gobgp and telemetry #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikos-github
approved these changes
Nov 6, 2018
zhenggen-xu
reviewed
Nov 6, 2018
| @@ -250,7 +250,7 @@ RUN apt-get update && apt-get install -y \ | |||
| RUN apt-get -y build-dep linux | |||
|
|
|||
| # For gobgp build | |||
| RUN export VERSION=1.8.3 \ | |||
There was a problem hiding this comment.
Any reason not using 1.11.2?
There was a problem hiding this comment.
No specific concrete reason. 1.11.1 is recent enough. could change it to 1.11.2 which was release a few days ago.
There was a problem hiding this comment.
I saw you upgraded to 1.11.2, since 1.11.2 is mostly backport bug fixes comparing to 1.11.1, this should be a good move.
| @@ -5,10 +5,10 @@ INSTALL := /usr/bin/install | |||
| all: gobgp gobgpd | |||
|
|
|||
| gobgpd: | |||
| go get -v github.com/osrg/gobgp/gobgpd | |||
| /usr/local/go/bin/go get -v github.com/osrg/gobgp/cmd/gobgpd | |||
There was a problem hiding this comment.
So the go path is not set with the new 1.11 version?
There was a problem hiding this comment.
if you log into slave docker, go is there. Somehow, it didn't work with the makefile.
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
jipanyang
changed the title
zhenggen-xu
approved these changes
Nov 7, 2018
| @@ -250,7 +250,7 @@ RUN apt-get update && apt-get install -y \ | |||
| RUN apt-get -y build-dep linux | |||
|
|
|||
| # For gobgp build | |||
| RUN export VERSION=1.8.3 \ | |||
There was a problem hiding this comment.
I saw you upgraded to 1.11.2, since 1.11.2 is mostly backport bug fixes comparing to 1.11.1, this should be a good move.
|
Retest this please |
|
@jipanyang Can you backport to 201803 as well? thx. |
vivekrnv
added a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Jun 24, 2022
430cd65 [202205] [generate dump] Move the Core/Log collection to the End of process Execution and removed default timeout (sonic-net#2230) 785508d [GCU] Handling type1 lists (sonic-net#2171) 56c2c6b [config reload] Fixing config reload when timer based services are disabled (sonic-net#2200) (sonic-net#2226) 600979e Fix header for the output table following 'show ipv6 interface' command (sonic-net#2219) Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
7 tasks
vivekrnv
added a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Jun 24, 2022
430cd65 [202205] [generate dump] Move the Core/Log collection to the End of process Execution and removed default timeout (sonic-net#2230) Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Jun 25, 2022
swss: * ad2d0ad 2022-06-24 | [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (sonic-net#2304) (HEAD -> 202205) [Vivek R] * ef75554 2022-06-25 | [swssconfig] Optimize performance of swssconfig (sonic-net#2336) [Junchao-Mellanox] * d9e9ba8 2022-06-24 | [fdborch] fix heap-use-after-free in clearFdbEntry() (sonic-net#2353) [Yakiv Huryk] * 585a69b 2022-06-24 | Create ACL table fails due to incorrect check for supported ACL actions sonic-net#11235 (sonic-net#2351) [Ravindranath C K] * 0d19560 2022-06-24 | [macsec] Refactor the logic of macsec name map (sonic-net#2348) [Junhua Zhai] * 111dfc2 2022-06-23 | [macsec] Update macsec flex counter (sonic-net#2338) (HEAD -> 202205, github/202205) [Junhua Zhai] swss-common: * 0213d55 2022-06-23 | [portcounter] Check if counter ID exists before arithmetic operation (sonic-net#632) (HEAD -> 202205, github/202205) [Junhua Zhai] * c21c47e 2022-06-14 | [counter] Add counter table (sonic-net#622) [Junhua Zhai] utilities: * 430cd65 2022-06-23 | [202205] [generate dump] Move the Core/Log collection to the End of process Execution and removed default timeout (sonic-net#2230) (github/202205) [Vivek R] linkmgrd: * 59334be 2022-06-24 | Remove exception throwing when initializing missing loopback interface (sonic-net#90) (HEAD -> 202205) [Jing Zhang] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
that referenced
this pull request
Jun 27, 2022
swss: * ad2d0ad 2022-06-24 | [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (#2304) (HEAD -> 202205) [Vivek R] * ef75554 2022-06-25 | [swssconfig] Optimize performance of swssconfig (#2336) [Junchao-Mellanox] * d9e9ba8 2022-06-24 | [fdborch] fix heap-use-after-free in clearFdbEntry() (#2353) [Yakiv Huryk] * 585a69b 2022-06-24 | Create ACL table fails due to incorrect check for supported ACL actions #11235 (#2351) [Ravindranath C K] * 0d19560 2022-06-24 | [macsec] Refactor the logic of macsec name map (#2348) [Junhua Zhai] * 111dfc2 2022-06-23 | [macsec] Update macsec flex counter (#2338) (HEAD -> 202205, github/202205) [Junhua Zhai] swss-common: * 0213d55 2022-06-23 | [portcounter] Check if counter ID exists before arithmetic operation (#632) (HEAD -> 202205, github/202205) [Junhua Zhai] * c21c47e 2022-06-14 | [counter] Add counter table (#622) [Junhua Zhai] utilities: * 430cd65 2022-06-23 | [202205] [generate dump] Move the Core/Log collection to the End of process Execution and removed default timeout (#2230) (github/202205) [Vivek R] linkmgrd: * 59334be 2022-06-24 | Remove exception throwing when initializing missing loopback interface (#90) (HEAD -> 202205) [Jing Zhang] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
robertvolkmann
pushed a commit
to robertvolkmann/sonic-buildimage
that referenced
this pull request
Jul 26, 2022
…et#11254) swss: * ad2d0ad 2022-06-24 | [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (sonic-net#2304) (HEAD -> 202205) [Vivek R] * ef75554 2022-06-25 | [swssconfig] Optimize performance of swssconfig (sonic-net#2336) [Junchao-Mellanox] * d9e9ba8 2022-06-24 | [fdborch] fix heap-use-after-free in clearFdbEntry() (sonic-net#2353) [Yakiv Huryk] * 585a69b 2022-06-24 | Create ACL table fails due to incorrect check for supported ACL actions sonic-net#11235 (sonic-net#2351) [Ravindranath C K] * 0d19560 2022-06-24 | [macsec] Refactor the logic of macsec name map (sonic-net#2348) [Junhua Zhai] * 111dfc2 2022-06-23 | [macsec] Update macsec flex counter (sonic-net#2338) (HEAD -> 202205, github/202205) [Junhua Zhai] swss-common: * 0213d55 2022-06-23 | [portcounter] Check if counter ID exists before arithmetic operation (sonic-net#632) (HEAD -> 202205, github/202205) [Junhua Zhai] * c21c47e 2022-06-14 | [counter] Add counter table (sonic-net#622) [Junhua Zhai] utilities: * 430cd65 2022-06-23 | [202205] [generate dump] Move the Core/Log collection to the End of process Execution and removed default timeout (sonic-net#2230) (github/202205) [Vivek R] linkmgrd: * 59334be 2022-06-24 | Remove exception throwing when initializing missing loopback interface (sonic-net#90) (HEAD -> 202205) [Jing Zhang] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
skbarista
pushed a commit
to skbarista/sonic-buildimage
that referenced
this pull request
Aug 17, 2022
…et#11254) swss: * ad2d0ad 2022-06-24 | [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (sonic-net#2304) (HEAD -> 202205) [Vivek R] * ef75554 2022-06-25 | [swssconfig] Optimize performance of swssconfig (sonic-net#2336) [Junchao-Mellanox] * d9e9ba8 2022-06-24 | [fdborch] fix heap-use-after-free in clearFdbEntry() (sonic-net#2353) [Yakiv Huryk] * 585a69b 2022-06-24 | Create ACL table fails due to incorrect check for supported ACL actions sonic-net#11235 (sonic-net#2351) [Ravindranath C K] * 0d19560 2022-06-24 | [macsec] Refactor the logic of macsec name map (sonic-net#2348) [Junhua Zhai] * 111dfc2 2022-06-23 | [macsec] Update macsec flex counter (sonic-net#2338) (HEAD -> 202205, github/202205) [Junhua Zhai] swss-common: * 0213d55 2022-06-23 | [portcounter] Check if counter ID exists before arithmetic operation (sonic-net#632) (HEAD -> 202205, github/202205) [Junhua Zhai] * c21c47e 2022-06-14 | [counter] Add counter table (sonic-net#622) [Junhua Zhai] utilities: * 430cd65 2022-06-23 | [202205] [generate dump] Move the Core/Log collection to the End of process Execution and removed default timeout (sonic-net#2230) (github/202205) [Vivek R] linkmgrd: * 59334be 2022-06-24 | Remove exception throwing when initializing missing loopback interface (sonic-net#90) (HEAD -> 202205) [Jing Zhang] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jipan Yang jipan.yang@alibaba-inc.com
- What I did
Address issue: #2229
Update go version to 1.11.1 and fix gobgp build
gobgp requires go 1.10 or newer.
Eventually we need go package version control like glide.
May extract this change with one PR: sonic-net/sonic-telemetry@c079dbd
- How I did it
- How to verify it
make target/debs/gobgp_1.16-01_amd64.deb
make target/debs/sonic-telemetry_0.1_amd64.deb
- Description for the changelog