[Dell] z9100 port qos & buffer changes of 0330 to master #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
lguohan
reviewed
Dec 5, 2018
| @@ -0,0 +1,1079 @@ | |||
| <DeviceMiniGraph xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns="Microsoft.Search.Autopilot.Evolution"> | |||
There was a problem hiding this comment.
remove minigraph, use default_sku
wendani
reviewed
Dec 5, 2018
| {% for port_idx in range(0, 128, 2) if port_idx not in [26, 30, 34, 38, 106, 110, 114, 118] %} | ||
| {% if PORT_ALL.append("Ethernet%d" % (port_idx)) %}{% endif %} | ||
| {% endfor %} | ||
| {%- endmacro %} |
There was a problem hiding this comment.
generate_port_lists() will not be called
yes will test it |
|
can you rebase to master, seems build is failing. |
Yes will do. |
DO NOT MERGE. Please merge after or along with PR 2239 sonic-net#2239 This commit has the forward porting of changes from 20180330 to master. Unit tested by checking the broadcom registers for the values. The values in hardware reflect the correct values except for TC to PFC priority group map values. Master branch values for TC to PFC priority group map for both z9100 and s6100 in incorrect, I have a build of Oct 12 master and the values are correct in that build. Signed-off-by: Harish Venkatraman <Harish_Venkatraman@Dell.com>
vharish02
force-pushed
the
z9100-0330-to-master
branch
from
bcaaacf
to
c9b70ab
Compare
Guohan the rebase was done and builds were successful, can you merge this PR. |
wendani
approved these changes
Jan 9, 2019
6 tasks
7 tasks
zbud-msft
added a commit
that referenced
this pull request
Jul 18, 2022
Why I did it 62b7b56 2022-07-13 | Remove disabled and not loaded services before calling reset-failed and restart services (#2266) [Zain Budhwani] 09b4678 2022-07-05 | [config/load_mgmt_config] Support load IPv6 mgmt IP (#2206) (#2246) [Jing Kan] How I did it Pulled latest commit from 201911 sonic-utilities branch and created PR How to verify it Look at build-image
vivekrnv
pushed a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE. Please merge after or along with PR 2239
#2239
This commit has the forward porting of changes from 20180330
to master. Unit tested by checking the broadcom registers
for the values. The values in hardware reflect the correct values
except for TC to PFC priority group map values. Master branch values
for TC to PFC priority group map for both z9100 and s6100 in incorrect,
I have a build of Oct 12 master and the values are correct in
that build.
Signed-off-by: Harish Venkatraman Harish_Venkatraman@Dell.com
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)