Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redis-py version #2273

Merged
merged 2 commits into from
Nov 19, 2018
Merged

Fix redis-py version #2273

merged 2 commits into from
Nov 19, 2018

Conversation

qiluo-msft
Copy link
Collaborator

@qiluo-msft qiluo-msft commented Nov 19, 2018

So we use specific stable version instead of latest one.
This is to partially fix sonic-net/sonic-utilities#379

Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
@lguohan lguohan merged commit b4fd40a into sonic-net:master Nov 19, 2018
@stcheng stcheng deleted the qiluo/fixredis branch November 19, 2018 20:16
@dzhangalibaba
Copy link
Collaborator

@qiluo-msft
is this the final fix ?
using specific stable version instead of latest one in both files/build_templates/sonic_debian_extension.j2 and sonic-py-swsssdk/setup.py is enough? we want to keep the same fix as the community does.

@qiluo-msft
Copy link
Collaborator Author

I believe it is enough. What is your concern exactly?

lguohan pushed a commit that referenced this pull request Nov 19, 2018
* Fix redis-py version

Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>

* Update submodule sonic-py-swsssdk: Fix redis-py version to 2.10.6

Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
@dzhangalibaba
Copy link
Collaborator

I believe it is enough. What is your concern exactly?

we make the same changes internally tand just want to make sure we didn't miss anything related to this issue. Looks we are good now. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config reload failed as incorrect arguments number for flushdb command
5 participants