[libteam]: Fix libteam race condition when interface is created and enslaved #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nslaved The race condition could happen like this: When an interface is enslaved into the port channel immediately after it is created, the order of creating the ifinfo and linking the ifinfo to the port is not guaranteed. Please check the patch commit message to get full details. Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
lguohan
approved these changes
Jan 16, 2019
|
Made to 201811 branch on 1/16/2019 |
yxieca
pushed a commit
that referenced
this pull request
Jan 16, 2019
…nslaved (#2449) The race condition could happen like this: When an interface is enslaved into the port channel immediately after it is created, the order of creating the ifinfo and linking the ifinfo to the port is not guaranteed. Please check the patch commit message to get full details. Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Sep 21, 2022
Update sonic-swss submodule pointer to include the following: * 8eea92e [202205][counters] Revert PR sonic-net#2432 for the buffer queue/pg counters improvement ([sonic-net#2462](sonic-net/sonic-swss#2462)) * 5d8636a [202205] Enhance orchagent and buffer manager in error handling (sonic-net#2414) ([sonic-net#2449](sonic-net/sonic-swss#2449)) * aa22237 [Everflow/ERSPAN] Set correct destination port and mac address when the nexthop is updated for ERSPAN mirror destination (sonic-net#2392) ([sonic-net#2455](sonic-net/sonic-swss#2455)) * 04ce7be check state_db for po before sending ARP/ND pkts (sonic-net#2444) ([sonic-net#2450](sonic-net/sonic-swss#2450)) * f0138a2 [portmgr] Fixed the orchagent crash due to late arrival of notif (sonic-net#2431) ([sonic-net#2451](sonic-net/sonic-swss#2451)) * 7cfde48 Change the log messages in addKernelNeigh/Route from ERROR to INFO ([sonic-net#2437](sonic-net/sonic-swss#2437)) * 2c5116e [202205][counters] Improve performance by polling only configured ports buffer queue/pg counters ([sonic-net#2432](sonic-net/sonic-swss#2432)) Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
prsunny
pushed a commit
that referenced
this pull request
Sep 21, 2022
Update sonic-swss submodule pointer to include the following: * 8eea92e [202205][counters] Revert PR #2432 for the buffer queue/pg counters improvement ([#2462](sonic-net/sonic-swss#2462)) * 5d8636a [202205] Enhance orchagent and buffer manager in error handling (#2414) ([#2449](sonic-net/sonic-swss#2449)) * aa22237 [Everflow/ERSPAN] Set correct destination port and mac address when the nexthop is updated for ERSPAN mirror destination (#2392) ([#2455](sonic-net/sonic-swss#2455)) * 04ce7be check state_db for po before sending ARP/ND pkts (#2444) ([#2450](sonic-net/sonic-swss#2450)) * f0138a2 [portmgr] Fixed the orchagent crash due to late arrival of notif (#2431) ([#2451](sonic-net/sonic-swss#2451)) * 7cfde48 Change the log messages in addKernelNeigh/Route from ERROR to INFO ([#2437](sonic-net/sonic-swss#2437)) * 2c5116e [202205][counters] Improve performance by polling only configured ports buffer queue/pg counters ([#2432](sonic-net/sonic-swss#2432))
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Oct 28, 2022
Update sonic-utilities submodule pointer to include the following: * 4a3d49d Fix exception in adding mirror_session when gre_type is absent ([sonic-net#2458](sonic-net/sonic-utilities#2458)) * 7e7d05c Update the DBmigrator to support persistent loglevel during warm-upgrade ([sonic-net#2370](sonic-net/sonic-utilities#2370)) * c2841b8 [doc]: Update Command-Reference.md ([sonic-net#2444](sonic-net/sonic-utilities#2444)) * 254cafc Event Counters CLI ([sonic-net#2449](sonic-net/sonic-utilities#2449)) * 2dab0d0 [techsupport] Adding FRR EVPN dumps ([sonic-net#2442](sonic-net/sonic-utilities#2442)) * 3c0aece [show][muxcable] add support for show mux firmware version all ([sonic-net#2441](sonic-net/sonic-utilities#2441)) Signed-off-by: dprital <drorp@nvidia.com>
liat-grozovik
pushed a commit
that referenced
this pull request
Oct 31, 2022
Update sonic-utilities submodule pointer to include the following: 4a3d49d Fix exception in adding mirror_session when gre_type is absent (#2458) 7e7d05c Update the DBmigrator to support persistent loglevel during warm-upgrade (#2370) c2841b8 [doc]: Update Command-Reference.md (#2444) 254cafc Event Counters CLI (#2449) 2dab0d0 [techsupport] Adding FRR EVPN dumps (#2442) 3c0aece [show][muxcable] add support for show mux firmware version all (#2441) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The race condition could happen like this:
When an interface is enslaved into the port channel immediately after
it is created, the order of creating the ifinfo and linking the ifinfo to
the port is not guaranteed.
Please check the patch commit message to get full details.
Signed-off-by: Shu0T1an ChenG shuche@microsoft.com