Create DaemonBase class for all daemons #2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
suggested changes
Feb 15, 2019
kevinwangsk
force-pushed
the
daemon_common
branch
from
4b060e5
to
fe06eb6
Compare
Done. |
jleveque
approved these changes
Feb 15, 2019
|
if this one is used by platform daemons, why cannot them be put into https://github.com/Azure/sonic-platform-daemons? |
|
@lguohan: It was my suggestion to add this to sonic-buildimage because these are functions I have written in many daemons both in the base image and in Docker containers. I think this library should be available system-wide to allow for code reuse. |
|
is this code here duplicated somewhere else? if yes, then we need also remove them. |
|
It is used in many daemons. Once this is merged, we can go through all the daemons and change them to import this library instead. |
lguohan
approved these changes
Feb 16, 2019
jleveque
reviewed
Feb 19, 2019
kevinwangsk
force-pushed
the
daemon_common
branch
from
fe06eb6
to
d9c36ac
Compare
Done. Wrap the common functions to a base class named daemon_util. |
kevinwangsk
force-pushed
the
daemon_common
branch
from
d9c36ac
to
0f11379
Compare
jleveque
suggested changes
Feb 20, 2019
kevinwangsk
force-pushed
the
daemon_common
branch
from
0f11379
to
18b2f87
Compare
kevinwangsk
force-pushed
the
daemon_common
branch
from
18b2f87
to
d151daf
Compare
kevinwangsk
changed the title
kevinwangsk
force-pushed
the
daemon_common
branch
from
d151daf
to
6b675dc
Compare
jleveque
approved these changes
Feb 27, 2019
DaemonBase is to wrap the common function of daemons, such as logging, signal handling, db connector, load specific platform plugins. Signed-off-by: Kevin Wang <kevinw@mellanox.com>
kevinwangsk
force-pushed
the
daemon_common
branch
from
6b675dc
to
f351cb7
Compare
liat-grozovik
pushed a commit
that referenced
this pull request
Jan 1, 2023
Update sonic-utilities submodule pointer to include the following: 3bc2bc6 [Mellanox][202205] Change severity to NOTICE in Mellanox buffer migrator when unable to fetch DEVICE_METADATA due to empty CONFIG_DB during initialization (#2570) e1c8243 [202205][generate_dump] Fix for a deletion flow for all secret files in the techsupport dump (#2572) 9f2984a [202205] Fix issue: unconfigured PGs are displayed in watermarkstat (#2568) f7988b0 [202205] [timer.unit.j2] use wanted-by in timer unit (#2561) f45dcfb [generate_dump] Optimize the execution time of 'show techsupport' CLI by paraller function execution (#2565) 67cbb15 [202205]Fixes 12170: Delete subinterface and recreate the subinterface in default-vrf (#2564) 93172c4 [202205] [generate_dump] Optimize the execution time of the 'show techsupport' script to 5-10% by reducing calls to the 'tar append' operation (#2562) Signed-off-by: dprital <drorp@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new python wheel is to wrap the common function of daemons,
such as logging, signal handling, load specific platform plugins.
Signed-off-by: Kevin Wang kevinw@mellanox.com
- What I did
Create a new python wheel named SONIC_DAEMON_COMMON_PY2 to wrap the common functions/macros for daemons.
- How I did it
- How to verify it
Change the daemons(ledd,xcvrd,psud) to import and use this common wheel. The daemons should work normally.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)