[hostcfgd]: Promote logs for update-notifications-from-DB from DEBUG to INFO #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Renuka Manavalan <remanava@microsoft.com>
…se notifications. All these changes are to help with a one-time-seen-bug, that hostcfgd did not act upon changes to redis for TACACS servers. We could not repro the bug. Signed-off-by: Renuka Manavalan <remanava@microsoft.com>
jleveque
approved these changes
Feb 16, 2019
lguohan
changed the title
|
looks good to me, btw, I modified the title to include the component so that it is easier to search later. |
|
Made to 201811 branch on 2/21/2019 |
yxieca
pushed a commit
that referenced
this pull request
Feb 21, 2019
…to INFO (#2576) * Add a log message for each notification of add/del TACACS server. Signed-off-by: Renuka Manavalan <remanava@microsoft.com> * Moved another syslog message from DEBUG to INFO to be able to see those notifications. All these changes are to help with a one-time-seen-bug, that hostcfgd did not act upon changes to redis for TACACS servers. We could not repro the bug. Signed-off-by: Renuka Manavalan <remanava@microsoft.com>
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…to INFO (sonic-net#2576) * Add a log message for each notification of add/del TACACS server. Signed-off-by: Renuka Manavalan <remanava@microsoft.com> * Moved another syslog message from DEBUG to INFO to be able to see those notifications. All these changes are to help with a one-time-seen-bug, that hostcfgd did not act upon changes to redis for TACACS servers. We could not repro the bug. Signed-off-by: Renuka Manavalan <remanava@microsoft.com>
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…to INFO (sonic-net#2576) * Add a log message for each notification of add/del TACACS server. Signed-off-by: Renuka Manavalan <remanava@microsoft.com> * Moved another syslog message from DEBUG to INFO to be able to see those notifications. All these changes are to help with a one-time-seen-bug, that hostcfgd did not act upon changes to redis for TACACS servers. We could not repro the bug. Signed-off-by: Renuka Manavalan <remanava@microsoft.com>
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…to INFO (sonic-net#2576) * Add a log message for each notification of add/del TACACS server. Signed-off-by: Renuka Manavalan <remanava@microsoft.com> * Moved another syslog message from DEBUG to INFO to be able to see those notifications. All these changes are to help with a one-time-seen-bug, that hostcfgd did not act upon changes to redis for TACACS servers. We could not repro the bug. Signed-off-by: Renuka Manavalan <remanava@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Changed syslog severity level of two log messages, from DEBUG to INFO. This is to help with getting insight into inputs received by hostcfgd at runtime.
- How I did it
Changed the severity level in the code.
- How to verify it
On a sonic switch with updated hostcfgd, use "config tacacs add " and/or "config tacacs delete " to add/remove an IP. Look for these updates in /var/log/syslog.
- Description for the changelog
<N/A>
- A picture of a cute animal (not mandatory but encouraged)