[buildsystem] Install debug packages in syncd when INSTALL_DEBUG_TOOLS=y #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
|
I don't think all SAI comes with dbg packet available. These SAI open sourced and built with sonic-buildimage will more likely have access to the dbg packet. But not others, e.g. Broadcom SAI doesn't have dbg packet available. You might want to remove this feature from these flavors of SAI. |
|
@yxieca This change does not install dbg packages for SAI vendor implementation; |
|
retest this please |
1 similar comment
|
retest this please |
|
@renukamanavalan , can you give your comments here? |
|
@stepanblyschak I see. thanks. |
qiluo-msft
reviewed
Apr 3, 2019
| @@ -9,7 +9,7 @@ debs/{{ deb }}{{' '}} | |||
| {%- endfor -%} | |||
| debs/ | |||
|
|
|||
| RUN dpkg -P syncd | |||
| RUN apt-get remove -y syncd | |||
qiluo-msft
reviewed
Apr 3, 2019
| @@ -9,7 +9,7 @@ debs/{{ deb }}{{' '}} | |||
| {%- endfor -%} | |||
| debs/ | |||
|
|
|||
| RUN dpkg -P syncd | |||
| RUN apt-get remove -y syncd | |||
qiluo-msft
reviewed
Apr 3, 2019
| @@ -9,7 +9,7 @@ debs/{{ deb }}{{' '}} | |||
| {%- endfor -%} | |||
| debs/ | |||
|
|
|||
| RUN dpkg -P syncd | |||
| RUN apt-get remove -y syncd | |||
|
purge is cleaner. |
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
lguohan
approved these changes
Apr 17, 2019
renukamanavalan
approved these changes
Apr 17, 2019
MichelMoriniaux
pushed a commit
to criteo-forks/sonic-buildimage
that referenced
this pull request
May 28, 2019
…S=y (sonic-net#2702) * [buildsystem] Install debug packages in syncd when INSTALL_DEBUG_TOOLS=y Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
8 tasks
prsunny
added a commit
that referenced
this pull request
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak stepanb@mellanox.com
- What I did
Install debug packages when INSTALL_DEBUG_TOOLS=y, the same way as with swss docker image;
- How to verify it
Installed docker syncd(rpc) image on DUT built with SONIC_DEBUGGING_ON=y and INSTALL_DEBUG_TOOLS=y
- Description for the changelog
[buildsystem] Install debug packages in syncd when INSTALL_DEBUG_TOOLS=y
- A picture of a cute animal (not mandatory but encouraged)