Test for quagga livelock fix #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The vs check must fail for now because this PR doesn't have the sonic-net/sonic-quagga#32 yet. I'll add it after the test shows it can catch the quagga livelock issue. |
|
retest this please |
|
vs test failed as expected with old version of quagga. |
lguohan
approved these changes
Apr 9, 2019
lguohan
pushed a commit
that referenced
this pull request
Apr 10, 2019
* Test for quagga livelock fix * Create /usr/local/etc for the test * Add more debug info * Install specific version of exabgp * Update sonic-quagga
yxieca
pushed a commit
that referenced
this pull request
Apr 16, 2019
* Test for quagga livelock fix * Create /usr/local/etc for the test * Add more debug info * Install specific version of exabgp * Update sonic-quagga
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added a test for quagga livelock fix. See sonic-net/sonic-quagga#32
- How I did it
Create a bgp session with r-bit set to 1 (default for exabgp) and wait until r-bit got inactive in quagga.
- How to verify it
Build an image and run the test
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)