[bgp quagga] increase BGP graceful restart timeout to 240 seconds #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some platforms with less powerful CPU/hard-drive could take longer to get ready for BGP. For these platforms, 240 seconds would be a safer threshold. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
zhenggen-xu
reviewed
Apr 9, 2019
| @@ -27,7 +27,7 @@ router bgp {{ DEVICE_METADATA['localhost']['bgp_asn'] }} | |||
| bgp log-neighbor-changes | |||
| bgp bestpath as-path multipath-relax | |||
| no bgp default ipv4-unicast | |||
| bgp graceful-restart restart-time 180 | |||
| bgp graceful-restart restart-time 240 | |||
There was a problem hiding this comment.
As per your description of the PR, it seems we are accommodating the value for some particular HW. I would think it is better to make it as a configurable item in minigraph/configDB. If not configured, the default is still 180, but on some particular platforms, we can increase the timer value.
lguohan
approved these changes
Apr 10, 2019
mihirpat1
pushed a commit
to mihirpat1/sonic-buildimage
that referenced
this pull request
Jun 14, 2023
…age if lag menber will be added to LAG after binding (sonic-net#2754) * Dual-ToR][ACL] bind LAG to ACL table in order to guarantee rule coverage if lag menber will be added to LAG after binding (sonic-net#2754)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
There are some platforms with less powerful CPU/hard-drive could take
longer to get ready for BGP. For these platforms, 240 seconds would be
a safer threshold.
Signed-off-by: Ying Xie ying.xie@microsoft.com