Increase syncd start timeout #2776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
qiluo-msft
reviewed
Apr 12, 2019
qiluo-msft
reviewed
Apr 14, 2019
| @@ -22,6 +22,9 @@ Environment=sonic_asic_platform={{ sonic_asic_platform }} | |||
| ExecStartPre=/usr/local/bin/syncd.sh start | |||
| ExecStart=/usr/local/bin/syncd.sh wait | |||
| ExecStop=/usr/local/bin/syncd.sh stop | |||
| {% if sonic_asic_platform == 'mellanox' %} | |||
| TimeoutSec=150 | |||
There was a problem hiding this comment.
TimeoutSec [](start = 0, length = 10)
Is it better to use TimeoutStartSec? #Closed
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
qiluo-msft
approved these changes
Apr 15, 2019
|
@andriymoroz-mlnx do we still want to merge this change after #2788 being merged to 201803? This is just a question, not a rejection :-) |
|
yes, because if after upgrade reboot will be via power/kernel crash/etc or user will not change default in GRUB but select it manually on boot we need this fix to let post-boot FW burn finish successfully |
jleveque
approved these changes
Apr 16, 2019
|
Just to summarize. |
yxieca
pushed a commit
that referenced
this pull request
Apr 26, 2019
* Increase syncd start timeout Signed-off-by: Andriy Moroz <c_andriym@mellanox.com> * Replace TimeoutSec to TimeoutStartSec Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
MichelMoriniaux
pushed a commit
to criteo-forks/sonic-buildimage
that referenced
this pull request
May 28, 2019
* Increase syncd start timeout Signed-off-by: Andriy Moroz <c_andriym@mellanox.com> * Replace TimeoutSec to TimeoutStartSec Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Moroz c_andriym@mellanox.com
- What I did
Increased syncd start timeout to let post-boot FW update on Mellanox platform finish successfully.
- How I did it
Added TimeoutSec field to the syncd service config
- How to verify it
Verified upgrade from 201803 to 201811 or master finishes successfully
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)