-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FRR]: Update frr to frr-7.0.1 #2899
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0b568b6
Update frr to frr-7.0.1
pavel-shirshov ec8a39e
Fix a typo
pavel-shirshov 145215e
Set right permissions on /etc/frr
pavel-shirshov 07d41bf
Convert external file links from debian to Azure
pavel-shirshov 6a9233f
Revert python3 fix
pavel-shirshov 43458a5
Build frr using more than 1 job
pavel-shirshov 0750571
Add SWIG as dependency for libswss-common
pavel-shirshov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,21 @@ | ||
# FRRouting (frr) package | ||
|
||
FRR_VERSION = 6.0.2 | ||
export FRR_VERSION | ||
FRR_VERSION = 7.0.1 | ||
FRR_SUBVERSION = 0 | ||
export FRR_VERSION FRR_SUBVERSION | ||
|
||
FRR = frr_$(FRR_VERSION)-1~sonic.debian9+1_amd64.deb | ||
$(FRR)_DEPENDS += $(LIBSNMP_DEV) | ||
|
||
FRR = frr_$(FRR_VERSION)-sonic-$(FRR_SUBVERSION)_amd64.deb | ||
$(FRR)_DEPENDS += $(LIBSNMP_DEV) $(LIBYANG_DEV) | ||
$(FRR)_RDEPENDS += $(LIBYANG) | ||
$(FRR)_SRC_PATH = $(SRC_PATH)/sonic-frr | ||
SONIC_MAKE_DEBS += $(FRR) | ||
SONIC_STRETCH_DEBS += $(FRR) | ||
|
||
FRR_PYTHONTOOLS = frr-pythontools_$(FRR_VERSION)-sonic-$(FRR_SUBVERSION)_all.deb | ||
$(eval $(call add_derived_package,$(FRR),$(FRR_PYTHONTOOLS))) | ||
|
||
FRR_DBG = frr-dbgsym_$(FRR_VERSION)-sonic-$(FRR_SUBVERSION)_amd64.deb | ||
$(eval $(call add_derived_package,$(FRR),$(FRR_DBG))) | ||
|
||
# FRRouting pythontools | ||
FRR_PYTHONTOOLS = frr-pythontools_$(FRR_VERSION)-1~sonic.debian9+1_amd64.deb | ||
$(FRR_PYTHONTOOLS)_DEPENDS += $(LIBSNMP_DEV) | ||
$(FRR_PYTHONTOOLS)_SRC_PATH = $(SRC_PATH)/sonic-frr | ||
SONIC_MAKE_DEBS += $(FRR_PYTHONTOOLS) | ||
export FRR FRR_PYTHONTOOLS FRR_DBG |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# libyang | ||
|
||
LIBYANG_VERSION_BASE = 0.16 | ||
LIBYANG_VERSION = $(LIBYANG_VERSION_BASE).105 | ||
LIBYANG_SUBVERSION = 1 | ||
|
||
export LIBYANG_VERSION_BASE | ||
export LIBYANG_VERSION | ||
export LIBYANG_SUBVERSION | ||
|
||
LIBYANG = libyang$(LIBYANG_VERSION_BASE)_$(LIBYANG_VERSION)-$(LIBYANG_SUBVERSION)_amd64.deb | ||
$(LIBYANG)_SRC_PATH = $(SRC_PATH)/libyang | ||
$(LIBYANG)_DEPENDS += $(SWIG_BASE) $(SWIG) | ||
SONIC_MAKE_DEBS += $(LIBYANG) | ||
SONIC_STRETCH_DEBS += $(LIBYANG) | ||
|
||
LIBYANG_DEV = libyang-dev_$(LIBYANG_VERSION)-$(LIBYANG_SUBVERSION)_amd64.deb | ||
$(eval $(call add_derived_package,$(LIBYANG),$(LIBYANG_DEV))) | ||
|
||
export LIBYANG LIBYANG_DEV |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# swig | ||
|
||
SWIG_VERSION_BASE = 3.0 | ||
SWIG_VERSION = $(SWIG_VERSION_BASE).12 | ||
SWIG_SUBVERSION = 2 | ||
|
||
export SWIG_VERSION_BASE | ||
export SWIG_VERSION | ||
export SWIG_SUBVERSION | ||
|
||
SWIG_BASE = swig$(SWIG_VERSION_BASE)_$(SWIG_VERSION)-$(SWIG_SUBVERSION)_amd64.deb | ||
$(SWIG_BASE)_SRC_PATH = $(SRC_PATH)/swig | ||
SONIC_MAKE_DEBS += $(SWIG_BASE) | ||
SONIC_STRETCH_DEBS += $(SWIG_BASE) | ||
|
||
SWIG = swig_$(SWIG_VERSION)-$(SWIG_SUBVERSION)_amd64.deb | ||
$(eval $(call add_derived_package,$(SWIG_BASE),$(SWIG))) | ||
|
||
SWIG_DBG = swig$(SWIG_VERSION_BASE)-dbgsym_$(SWIG_VERSION)-$(SWIG_SUBVERSION)_amd64.deb | ||
$(eval $(call add_derived_package,$(SWIG_BASE),$(SWIG_DBG))) | ||
|
||
export SWIG_BASE SWIG SWIG_DBG |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
.ONESHELL: | ||
SHELL = /bin/bash | ||
.SHELLFLAGS += -e | ||
|
||
MAIN_TARGET = $(LIBYANG) | ||
DERIVED_TARGETS = $(LIBYANG_DEV) | ||
|
||
$(addprefix $(DEST)/, $(MAIN_TARGET)): $(DEST)/% : | ||
rm -fr ./libyang-$(LIBYANG_VERSION) | ||
wget -O libyang_$(LIBYANG_VERSION).orig.tar.gz 'https://sonicstorage.blob.core.windows.net/packages/libyang_0.16.105.orig.tar.gz?sv=2015-04-05&sr=b&sig=yTWDhl6B9TTXWAQ46zpLiNxUib61W7U0%2F%2FGvhRibKOc%3D&se=2046-09-30T22%3A10%3A27Z&sp=r' | ||
wget -O libyang_$(LIBYANG_VERSION).dsc 'https://sonicstorage.blob.core.windows.net/packages/libyang_0.16.105-1.dsc?sv=2015-04-05&sr=b&sig=eLkO5wzB1C5oKNIaUPro4gwrgEC3EygIO6eCyTzHmeI%3D&se=2046-09-30T22%3A10%3A12Z&sp=r' | ||
wget -O libyang_$(LIBYANG_VERSION)-$(LIBYANG_SUBVERSION).debian.tar.xz 'https://sonicstorage.blob.core.windows.net/packages/libyang_0.16.105-1.debian.tar.xz?sv=2015-04-05&sr=b&sig=AH18p7pKK0xIBVxZuA8EMv9%2FhXbCFKmbWAn7Za8%2BZW4%3D&se=2046-09-30T22%3A09%3A36Z&sp=r' | ||
dpkg-source -x libyang_$(LIBYANG_VERSION).dsc | ||
|
||
pushd ./libyang-$(LIBYANG_VERSION) | ||
dpkg-buildpackage -rfakeroot -b -us -uc -j$(SONIC_CONFIG_MAKE_JOBS) | ||
popd | ||
|
||
mv $(DERIVED_TARGETS) $* $(DEST)/ | ||
|
||
$(addprefix $(DEST)/, $(DERIVED_TARGETS)): $(DEST)/% : $(DEST)/$(MAIN_TARGET) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule frr
updated
from 5a35fd to cd305c
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
.ONESHELL: | ||
SHELL = /bin/bash | ||
.SHELLFLAGS += -e | ||
|
||
MAIN_TARGET = $(SWIG_BASE) | ||
DERIVED_TARGETS = $(SWIG) $(SWIG_DBG) | ||
|
||
$(addprefix $(DEST)/, $(MAIN_TARGET)): $(DEST)/% : | ||
rm -fr ./swig-$(SWIG_VERSION) *.deb | ||
wget -O swig_$(SWIG_VERSION).orig.tar.gz 'https://sonicstorage.blob.core.windows.net/packages/swig_3.0.12.orig.tar.gz?sv=2015-04-05&sr=b&sig=kcSKFvlTQZst8Dbb8MUfckGbVEZU5sptFqT2HbwOUtA%3D&se=2046-09-30T22%3A11%3A59Z&sp=r' | ||
wget -O swig_$(SWIG_VERSION).dsc 'https://sonicstorage.blob.core.windows.net/packages/swig_3.0.12-2.dsc?sv=2015-04-05&sr=b&sig=k3eLfmWgmCz1Kx8SYcirX18FSQdJ76ifo%2B9rbJBnrf8%3D&se=2046-09-30T22%3A11%3A45Z&sp=r' | ||
wget -O swig_$(SWIG_VERSION)-$(SWIG_SUBVERSION).debian.tar.xz 'https://sonicstorage.blob.core.windows.net/packages/swig_3.0.12-2.debian.tar.xz?sv=2015-04-05&sr=b&sig=SQICTE%2BR1BO7npUBNwTQjo447OaFz%2BooX6VAm912c7g%3D&se=2046-09-30T22%3A11%3A32Z&sp=r' | ||
dpkg-source -x swig_$(SWIG_VERSION).dsc | ||
|
||
pushd ./swig-$(SWIG_VERSION) | ||
dpkg-buildpackage -rfakeroot -b -us -uc -j$(SONIC_CONFIG_MAKE_JOBS) | ||
popd | ||
|
||
mv $(DERIVED_TARGETS) $* $(DEST)/ | ||
|
||
$(addprefix $(DEST)/, $(DERIVED_TARGETS)): $(DEST)/% : $(DEST)/$(MAIN_TARGET) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lguohan @pavel-shirshov can we force this fix with a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavel-shirshov our regression fails because frr is missing staticd which is essential part of this suite, so i would like to ask you to force this fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nazarii-gnydyn
Can you please share some output?
On our side I see:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavel-shirshov On our side (without this fix):