Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Update platform driver service options #2908

Merged
merged 1 commit into from
May 20, 2019

Conversation

andriymoroz-mlnx
Copy link
Collaborator

Signed-off-by: Andriy Moroz c_andriym@mellanox.com

- What I did
Updated platform driver service options

- How I did it
Updated patch file which creates service config

- How to verify it
load minigraph, make sure MAC address fetched successfully

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
@qiluo-msft
Copy link
Collaborator

qiluo-msft commented May 16, 2019

I notice swss will influence this service.

ExecStartPre=/bin/bash -c "/usr/share/sonic/device/$(sonic-cfggen -H -v DEVICE_METADATA.localhost.platform)/hw-management start"
ExecStopPost=/bin/bash -c "/usr/share/sonic/device/$(sonic-cfggen -H -v DEVICE_METADATA.localhost.platform)/hw-management stop"

Suggest make them consistent with each other. #Closed

Copy link
Collaborator

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As comment

@andriymoroz-mlnx
Copy link
Collaborator Author

I notice swss will influence this service.
...
Suggest make them consistent with each other.

There is difference between this two starts.
Before updategraph is needed probably only once - on config creation when eeprom cache is missing. It is started without SDK module loaded (to start faster) and some components may not work.
Swss is wrapped in "full start" and should happen on every boot/restart
All hw-management services are fine after first partial start followed by full start

@lguohan lguohan merged commit a78812b into sonic-net:201803 May 20, 2019
yxieca pushed a commit that referenced this pull request Jul 13, 2023
…atically (#15809)

src/sonic-utilities

* 20853a6f - (HEAD -> 202205, origin/202205) Revert "[GCU Feature Update] Cherry-pick Platform Validator PR to 202205  (#2883)" (#2908) (6 hours ago) [isabelmsft]
mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024
Submodule update] azure/sonic-utilities.msft update to latest HEAD
* 20853a6 Revert "[GCU Feature Update] Cherry-pick Platform Validator PR to 202205  (sonic-net#2883)" (sonic-net#2908)
* 0ea47b4 [db_migrator] Remove hardcoded config and migrate config from minigraph (sonic-net#2887)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants