[mlnx] fix incorrect attr assignment in mlnx-sfpd #2913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
added 2 commits
May 17, 2019 16:01
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
lguohan
approved these changes
May 18, 2019
yxieca
pushed a commit
that referenced
this pull request
May 20, 2019
* [mlnx] fix incorrect attr assignment in mlnx-sfpd Signed-off-by: Stepan Blyschak <stepanb@mellanox.com> * [mlnx] on_pmpe returns bool and not SX_STATUS_SUCCESS Signed-off-by: Stepan Blyschak <stepanb@mellanox.com> * [mlnx] fix typo Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
MichelMoriniaux
pushed a commit
to criteo-forks/sonic-buildimage
that referenced
this pull request
May 28, 2019
* [mlnx] fix incorrect attr assignment in mlnx-sfpd Signed-off-by: Stepan Blyschak <stepanb@mellanox.com> * [mlnx] on_pmpe returns bool and not SX_STATUS_SUCCESS Signed-off-by: Stepan Blyschak <stepanb@mellanox.com> * [mlnx] fix typo Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak stepanb@mellanox.com
To fix bug introduced in #2907 . Now tested with cable plug in/plug out
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)