move loopback configuration to intfMgrd #3044

tylerlinp · 2019-06-19T11:52:06Z

- What I did
Sonic supports multiple loopback interfaces. Each loopback interfaces can belong to different Vrf.

- How I did it
IntfMgrd will take interface-config.service instead to handle loopback interface configuration.

- How to verify it
Pass vrf vs test cases and ansible test cases.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Merge Azure/sonic-buildimage

jleveque · 2019-06-20T01:35:07Z

Retest this please

prsunny · 2019-06-20T21:59:18Z

Can you please look at the build failures. You may want to fix this file files/image_config/interfaces/interfaces.j2

Fix merging error in last commit

tylerlinp · 2019-06-21T06:47:41Z

Sorry, I made a mistake when merging.

Modify test sample_output file

lguohan · 2019-06-23T18:57:03Z

what is the pr for intfmgrd to support lo? we need both both into the buildimage at the same time.

tylerlinp · 2019-06-25T13:02:00Z

what is the pr for intfmgrd to support lo? we need both both into the buildimage at the same time.

sonic-swss PR:
sonic-net/sonic-swss#943

nikos-github · 2019-07-25T09:35:49Z

files/image_config/interfaces/interfaces.j2

@@ -9,13 +9,6 @@
 # The loopback network interface
 auto lo
 iface lo inet loopback
-# Use command 'ip addr list dev lo' to check all addresses


@tylerlinp @prsunny Any reason why the approach used for mgmt i/f being in the vrf can't be followed for lo? Not even sure that lo should be allowed to be in a vrf. How will redis work if lo is in a vrf?

@tylerlinp @prsunny Any reason why the approach used for mgmt i/f being in the vrf can't be followed for lo? Not even sure that lo should be allowed to be in a vrf. How will redis work if lo is in a vrf?

All loopback interfaces map to device lo, that cause conflict when loopbacks belong to differents vrfs. I think lo shouldn't be add to a vrf, even though kernel don't restrict doing so. Some process which communicates locally may be affected. It is good to add a device for every loopback interface(LoopbackXXX), then lo keep original function. Then LoopbackXXX is add vrf/ip just like other l3 interface.

Yes I understand the issue. However, you are taking away the ability to further statically configure lo with this change. The right approach to follow would be to leave lo configuration where it is and make sure other loopbacks don't map to the same loopback device.

Yes I understand the issue. However, you are taking away the ability to further statically configure lo with this change. The right approach to follow would be to leave lo configuration where it is and make sure other loopbacks don't map to the same loopback device.

What configuration do you mean? The ip addresses only config to kernel? If not add to ASIC, I think the addresses except 127.x.x.x & ::1 would be useless. If truely needed, maybe should filter configuration like LOOPBACK_INTERFACE|lo|1.1.1.1/32 and then add to interfaces.

nikos-github · 2019-07-25T16:57:55Z

files/image_config/interfaces/interfaces.j2

@@ -9,13 +9,6 @@
 # The loopback network interface
 auto lo
 iface lo inet loopback
-# Use command 'ip addr list dev lo' to check all addresses


Yes I understand the issue. However, you are taking away the ability to further statically configure lo with this change. The right approach to follow would be to leave lo configuration where it is and make sure other loopbacks don't map to the same loopback device.

shine4chen · 2019-07-26T05:35:14Z

@nikos-github This is the loopback device consideration which will add to upcoming vrf-hld-1.2.

Sonic must support multiple loopback interfaces and each loopback interface can belong to different vrf. Because linux kernel can only support one lo interface. We will use dummy interface instead of lo interface in linux kernel.

The following is the example to configure new loopback interface by using dummy interface

ip link add loopback1 type dummy
ip link set loopback1 up
ip link set dev loopback1 master Vrf_blue
ip address add 10.0.2.2/32 dev loopback1

In existing implementation interface-config.service takes care of loopback configuration. IntfMgrd will take interface-config.service instead to handle it.

prsunny · 2019-10-09T22:23:10Z

retest this please

tylerlinp · 2019-10-12T08:13:16Z

retest this please

Merge branch 'master' into loopback, remove blank line

tylerlinp · 2019-11-07T03:02:09Z

@prsunny It is better to merge this PR together with sonic-swss/943.

prsunny · 2019-11-07T03:04:03Z

Yes @tylerlinp. We need to update swss submodule. Can you update this PR with submodule update?

shine4chen · 2019-11-07T03:08:01Z

@prsunny this PR should be merged since PR 943 has been merged.

tylerlinp · 2019-11-07T03:15:51Z

Yes @tylerlinp. We need to update swss submodule. Can you update this PR with submodule update?

OK, I will do it.

prsunny · 2019-11-07T03:33:01Z

Ok great, I saw you updated the submodule. I'll close my PR #3720

Submodules update here:

85ff17d - 2019-11-07 : [VRF]: submit vrf feature (#943) [Tyler Li]
5604566 - 2019-11-06 : [vs_test] fix fdb test failed randomly (#1118) [Tyler Li]
038d994 - 2019-11-05 : [vnet]: Correct VNET route table size for BITMAP implementation (#1115) [Volodymyr Samotiy]
bb4e19c - 2019-11-04 : Not wait till kernel net_devices are created for all physical ports to (#1109) [Wenda Ni]
bab7b93 - 2019-11-02 : [portsorch] fix PortsOrch::allPortsReady() returns true when it should not (#1103) [Stepan Blyshchak]
5ab3f6b - 2019-10-31 : Updating pytest for sflow (#1095) [Sudharsan D.G]
d4ccdc3 - 2019-10-29 : Quote input strings before constructing a command line (#1098) [Qi Luo]
5516ec4 - 2019-10-29 : Check RIF/Port exists only for add entries (#1110) [Prince Sunny]
59440f2 - 2019-10-29 : Allow buffer profile apply after init (#1099) [Wenda Ni]

tylerlinp · 2019-11-07T08:46:58Z

retest this please

tylerlinp · 2019-11-07T09:32:03Z

@prsunny It seems that there is problem to build mock_tests when building normal image, not generate Makefile but want to make.

prsunny · 2019-11-07T23:30:03Z

retest broadcom please

prsunny · 2019-11-07T23:30:13Z

retest mellanox please

prsunny · 2019-11-08T00:54:14Z

@tylerlinp , we are working on the build failure

prsunny · 2019-11-08T01:14:01Z

sonic-net/sonic-swss#1122

prsunny · 2019-11-09T03:02:16Z

@tylerlinp , can you update PR with this commit - sonic-net/sonic-swss#1123 ?

shine4chen · 2019-11-09T04:07:34Z

retest broadcom please

lguohan · 2019-11-09T21:59:15Z

check #3733

tylerlinp · 2019-11-11T10:29:06Z

The commits have been cherry-picked to PR #3733 which has been merged. That's great, so this PR can be closed directlly.

tylerlinp · 2019-11-12T01:12:43Z

retest vs please

prsunny · 2019-11-12T18:50:11Z

Closing in favor of #3733

…lly (#18079) 788def1f - (HEAD -> 202205, origin/202205) Fix the Orchagent crash seen during Port channel OC test cases. (#3042) (#3044) (3 minutes ago) [mssonicbld]

tylerlinp and others added 2 commits June 12, 2019 19:50

Merge pull request #1 from Azure/master

bfaaba1

Merge Azure/sonic-buildimage

Loopback ip addresses move to intfmgrd for supporting VRF

8ce86f3

jleveque requested a review from prsunny June 20, 2019 01:34

jleveque added the Enhancement ➕ label Jun 20, 2019

Loopback ip addresses move to intfmgrd for supporting VRF

3eb72a7

Fix merging error in last commit

Loopback ip addresses move to intfmgrd for supporting VRF

587bd8f

Modify test sample_output file

nikos-github suggested changes Jul 25, 2019

View reviewed changes

dawnbeauty mentioned this pull request Aug 12, 2019

[tests/vrf] Submit VRF testcases according to vrf test plan sonic-net/sonic-mgmt#1065

Merged

1 task

prsunny approved these changes Sep 13, 2019

View reviewed changes

prsunny mentioned this pull request Sep 13, 2019

Interface template update for Loopback interface per VRF support #3171

Closed

Merge branch 'master' into loopback

b430222

Tyler Li and others added 2 commits October 12, 2019 18:09

Update interfaces.j2

33687ca

Merge branch 'master' into loopback, remove blank line

Merge branch 'master' into loopback, modify new sample_output

87753d2

Tyler Li added 2 commits November 6, 2019 19:18

Merge https://github.com/Azure/sonic-buildimage into loopback

5a8df55

update submodule src/sonic-swss

39102a7

Tyler Li added 2 commits November 10, 2019 17:29

update submodule src/sonic-swss

d9c74d3

Merge https://github.com/Azure/sonic-buildimage into loopback

1dcec0d

prsunny closed this Nov 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move loopback configuration to intfMgrd #3044

move loopback configuration to intfMgrd #3044

tylerlinp commented Jun 19, 2019

jleveque commented Jun 20, 2019

prsunny commented Jun 20, 2019

tylerlinp commented Jun 21, 2019

lguohan commented Jun 23, 2019

tylerlinp commented Jun 25, 2019 •

edited

Loading

nikos-github Jul 25, 2019

tylerlinp Jul 25, 2019

nikos-github Jul 25, 2019 •

edited

Loading

tylerlinp Jul 26, 2019

nikos-github Jul 25, 2019 •

edited

Loading

shine4chen commented Jul 26, 2019

prsunny commented Oct 9, 2019

tylerlinp commented Oct 12, 2019

tylerlinp commented Nov 7, 2019

prsunny commented Nov 7, 2019

shine4chen commented Nov 7, 2019

tylerlinp commented Nov 7, 2019

prsunny commented Nov 7, 2019

tylerlinp commented Nov 7, 2019

tylerlinp commented Nov 7, 2019

prsunny commented Nov 7, 2019

prsunny commented Nov 7, 2019

prsunny commented Nov 8, 2019

prsunny commented Nov 8, 2019

prsunny commented Nov 9, 2019

shine4chen commented Nov 9, 2019

lguohan commented Nov 9, 2019

tylerlinp commented Nov 11, 2019

tylerlinp commented Nov 12, 2019

prsunny commented Nov 12, 2019

move loopback configuration to intfMgrd #3044

move loopback configuration to intfMgrd #3044

Conversation

tylerlinp commented Jun 19, 2019

jleveque commented Jun 20, 2019

prsunny commented Jun 20, 2019

tylerlinp commented Jun 21, 2019

lguohan commented Jun 23, 2019

tylerlinp commented Jun 25, 2019 • edited Loading

nikos-github Jul 25, 2019

Choose a reason for hiding this comment

tylerlinp Jul 25, 2019

Choose a reason for hiding this comment

nikos-github Jul 25, 2019 • edited Loading

Choose a reason for hiding this comment

tylerlinp Jul 26, 2019

Choose a reason for hiding this comment

nikos-github Jul 25, 2019 • edited Loading

Choose a reason for hiding this comment

shine4chen commented Jul 26, 2019

prsunny commented Oct 9, 2019

tylerlinp commented Oct 12, 2019

tylerlinp commented Nov 7, 2019

prsunny commented Nov 7, 2019

shine4chen commented Nov 7, 2019

tylerlinp commented Nov 7, 2019

prsunny commented Nov 7, 2019

tylerlinp commented Nov 7, 2019

tylerlinp commented Nov 7, 2019

prsunny commented Nov 7, 2019

prsunny commented Nov 7, 2019

prsunny commented Nov 8, 2019

prsunny commented Nov 8, 2019

prsunny commented Nov 9, 2019

shine4chen commented Nov 9, 2019

lguohan commented Nov 9, 2019

tylerlinp commented Nov 11, 2019

tylerlinp commented Nov 12, 2019

prsunny commented Nov 12, 2019

tylerlinp commented Jun 25, 2019 •

edited

Loading

nikos-github Jul 25, 2019 •

edited

Loading

nikos-github Jul 25, 2019 •

edited

Loading