Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dell]Poller to detecte Intel Rangely C2000 LPC degradation #3065

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

dgsudharsan
Copy link
Collaborator

- What I did
Added Daemon to Log LPC bus degradation in Intel C2000 processor. Intel Rangeley C2000 processors with revision less than or equal to 2 have issue where LPC bus degrades over time in some processors. To identify the problem and to notify the issue, a daemon has been added which will log on encountering the issue.

- How I did it
Added a daemon which validates the CPLD scratch(0x102) and SMF scratch(0x202) registers by writing and reading values on regular polling intervals (300 seconds). If there is a discrepancy between read and write, a critical log will be thrown.

- How to verify it
The infra is verify by simulating the issue where between write and read, the value in register is modified and the log appearance is checked.

- Description for the changelog

Added Daemon to identify LPC bus degradation issue and notify using syslog in Dell S6100 and Z9100 platforms. This daemon will only run on processors with revision less than or equal to 2.

- A picture of a cute animal (not mandatory but encouraged)

@lguohan
Copy link
Collaborator

lguohan commented Jun 22, 2019

retest vs please

@lguohan
Copy link
Collaborator

lguohan commented Jun 23, 2019

can you resolve conflict?

Adding execute permissions

Changing service permission

Addressing review comment

chaning s6100 permission

Added more info in log
@dgsudharsan
Copy link
Collaborator Author

can you resolve conflict?

Done

@lguohan lguohan merged commit 2e40fa5 into sonic-net:master Jun 24, 2019
@dgsudharsan dgsudharsan deleted the lpc_detect branch October 8, 2019 05:40
yxieca pushed a commit that referenced this pull request Jan 6, 2020
…s6100 (#3065)

- What I did
Added Daemon to Log LPC bus degradation in Intel C2000 processor. Intel Rangeley C2000 processors with revision less than or equal to 2 have issue where LPC bus degrades over time in some processors. To identify the problem and to notify the issue, a daemon has been added which will log on encountering the issue.

- How I did it
Added a daemon which validates the CPLD scratch(0x102) and SMF scratch(0x202) registers by writing and reading values on regular polling intervals (300 seconds). If there is a discrepancy between read and write, a critical log will be thrown.

- How to verify it
The infra is verify by simulating the issue where between write and read, the value in register is modified and the log appearance is checked.

- Description for the changelog

Added Daemon to identify LPC bus degradation issue and notify using syslog in Dell S6100 and Z9100 platforms. This daemon will only run on processors with revision less than or equal to 2.
@li-pingmao
Copy link
Contributor

Do you know the lifetime for this CPLD device?

Flash and CPLD normally have lifetime of writes on 10k range, in case of flash controller writes can be increased to millions.

Is writing to CPLD registers every 300 seconds a good option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants