Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[201811] Build debug dockers and debug one image #3104

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

renukamanavalan
Copy link
Contributor

@renukamanavalan renukamanavalan commented Jul 1, 2019

  1. Build debug docker image for each docker
  2. Install debug tools in every debug docker image
  3. Install available debug symbols in debug docker image
  4. Provide additional host/docker mapping for host dirs /src & /debug
    4.1) The one-image will have source code under /src
    4.2) /debug is mapped as rw. User can put his core file there and use this dir to
    collect debug session logs too.
  5. Build debug image using debug dockers
  6. Source code is archived into /src of debug image
  7. The welcome banner is extended to display these additional facilities in debug image.

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

2) Install debug tools in every debug docker image
3) Install available debug symbols in debug docker image
4) Provide additional host/docker mapping for host dirs /src & /debug
    4.1) The one-image will have source code under /src
    4.2) /debug is mapped as rw. User can put his core file there and use this dir to
         collect debug session logs too.
5) Build debug image using debug dockers
6) Source code is archived into /src of debug image
7) The welcome banner is extended to display these additional facilities in debug image.
@lguohan
Copy link
Collaborator

lguohan commented Jul 3, 2019

what is the relation with #3098

@renukamanavalan
Copy link
Contributor Author

Same feature, but cannot be cherry picked. So completely re-done for Nov branch, where dockers are not stretch based. Plus, many of the debug symbols that are available in master is not available in Nov.

This is the initial checkin.

After this, I plan to do a comparison with Masters and see how we can get more symbols for Nov, as this is crucial/important for us.

@jleveque
Copy link
Contributor

jleveque commented Jul 3, 2019

Why does the title of this PR begin with "1)"? 1 of what?

@renukamanavalan renukamanavalan changed the title 1) Build debug docker image for each docker Build debug dockers and debug one image Jul 3, 2019
@renukamanavalan
Copy link
Contributor Author

I missed to notice/remember that first line of comments become the title. Corrected.

@jleveque
Copy link
Contributor

jleveque commented Jul 3, 2019

When creating a PR against any branch other than master, I have been prepending the branch name to the beginning of the title. I believe this helps eliminate confusion when looking over the PRs. For example, I suggest you rename this PR as follows:

[201811] Build debug dockers and debug one image

@renukamanavalan renukamanavalan changed the title Build debug dockers and debug one image [201811] Build debug dockers and debug one image Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants