[Mellanox]new platform api -- support get_change_event #3142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…latform api remove the standalong daemon which is in charge of polling sfp change event through sdk interface and move the polling stuff to the event in the chassis daemon.
stephenxs
changed the title
keboliu
approved these changes
Jul 12, 2019
jleveque
approved these changes
Jul 12, 2019
liat-grozovik
requested changes
Jul 15, 2019
platform/mellanox/mlnx-platform-api/sonic_platform/sfp_event.py
Outdated
Show resolved
Hide resolved
liat-grozovik
approved these changes
Jul 24, 2019
|
retest vs please |
3 similar comments
|
retest vs please |
|
retest vs please |
|
retest vs please |
stephenxs
added a commit
to stephenxs/sonic-buildimage
that referenced
this pull request
Jul 31, 2019
* [Mellanox]refractor the sfp event change notification logic for new platform api remove the standalong daemon which is in charge of polling sfp change event through sdk interface and move the polling stuff to the event in the chassis daemon. * rephase some comment * fix typo in sfp_event.sfp_event.initialize Conflicts: platform/mellanox/mlnx-platform-api/sonic_platform/chassis.py
mssonicbld
added a commit
that referenced
this pull request
May 11, 2024
…lly (#18935) #### Why I did it src/sonic-swss ``` * 198eb3d1 - (HEAD -> master, origin/master, origin/HEAD) Add transceiver info to bake only if supported (#3142) (2 hours ago) [Sudharsan Dhamal Gopalarathnam] * f62eed23 - [Mellanox] PFC watchdog long term solution to reduce false alarm (#3036) (35 hours ago) [Stephen Sun] ``` #### How I did it #### How to verify it #### Description for the changelog
mssonicbld
added a commit
that referenced
this pull request
Jul 3, 2024
…lly (#19432) #### Why I did it src/sonic-swss ``` * 8fd0837a - (HEAD -> 202311, origin/202311) Add support for ECMP and LAG hash offset (#3138) (4 hours ago) [Kumaresh Perumal] * 66b9dacf - [Mellanox] PFC watchdog long term solution to reduce false alarm (#3036) (4 hours ago) [Stephen Sun] * 14add20e - Revamp module build script to make it work for 5.15 on Ubuntu 20.04 (#3212) (7 hours ago) [Saikrishna Arcot] * 6a347ab4 - Add transceiver info to bake only if supported (#3142) (5 days ago) [Sudharsan Dhamal Gopalarathnam] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
implement new platform api sfp event change part.
- How I did it
remove the old logic in which a standalone daemon mlnx-sfpd polls sfp change event through sdk interface, posts event to database and xcvrd daemon receive notification from database.
implement the new logic in which chassis class polls the sfp change event through sdk directly and database is no longer used.
- How to verify it
plug in/out multiple sfp module while calling chassis.get_change_event() interface, all change event should be returned by the interface through a single call.
should not observe any memory usage increasing.
- Description for the changelog
[Mellanox]new platform api -- sfp event change
- A picture of a cute animal (not mandatory but encouraged)