-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build]: Fix comparing docker versions #3205
Merged
lguohan
merged 10 commits into
sonic-net:master
from
pavel-shirshov:pavelsh/fix_docker_version
Jul 23, 2019
Merged
[build]: Fix comparing docker versions #3205
lguohan
merged 10 commits into
sonic-net:master
from
pavel-shirshov:pavelsh/fix_docker_version
Jul 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
approved these changes
Jul 23, 2019
lguohan
changed the title
Fix comparing docker versions
[build]: Fix comparing docker versions
Jul 23, 2019
Probably it's better to fix it using |
jleveque
approved these changes
Jul 23, 2019
mssonicbld
added a commit
that referenced
this pull request
Jul 6, 2024
…lly (#19461) #### Why I did it src/sonic-swss ``` * 43ac585c - (HEAD -> master, origin/master, origin/HEAD) Revamp module build script to make it work for 5.15 on Ubuntu 20.04 (#3212) (3 days ago) [Saikrishna Arcot] * c9c78dc4 - Fix in switchorch: unsupported attribute causes skipping of processing the rest of configurations (#3209) (3 days ago) [Amir] * 0158d27d - [Chassis][voq] do not synchronize the system interface state if there is no rif assciated with the port (#3207) (3 days ago) [Arvindsrinivasan Lakshmi Narasimhan] * fdd5bdc9 - [vxlanmgr]: Add disabling of fdb learning for linux vxlan interfaces (#3205) (3 days ago) [yfedoriachenko] ``` #### How I did it #### How to verify it #### Description for the changelog
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
…lly (sonic-net#19461) #### Why I did it src/sonic-swss ``` * 43ac585c - (HEAD -> master, origin/master, origin/HEAD) Revamp module build script to make it work for 5.15 on Ubuntu 20.04 (sonic-net#3212) (3 days ago) [Saikrishna Arcot] * c9c78dc4 - Fix in switchorch: unsupported attribute causes skipping of processing the rest of configurations (sonic-net#3209) (3 days ago) [Amir] * 0158d27d - [Chassis][voq] do not synchronize the system interface state if there is no rif assciated with the port (sonic-net#3207) (3 days ago) [Arvindsrinivasan Lakshmi Narasimhan] * fdd5bdc9 - [vxlanmgr]: Add disabling of fdb learning for linux vxlan interfaces (sonic-net#3205) (3 days ago) [yfedoriachenko] ``` #### How I did it #### How to verify it #### Description for the changelog
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Aug 1, 2024
…lly (sonic-net#19461) #### Why I did it src/sonic-swss ``` * 43ac585c - (HEAD -> master, origin/master, origin/HEAD) Revamp module build script to make it work for 5.15 on Ubuntu 20.04 (sonic-net#3212) (3 days ago) [Saikrishna Arcot] * c9c78dc4 - Fix in switchorch: unsupported attribute causes skipping of processing the rest of configurations (sonic-net#3209) (3 days ago) [Amir] * 0158d27d - [Chassis][voq] do not synchronize the system interface state if there is no rif assciated with the port (sonic-net#3207) (3 days ago) [Arvindsrinivasan Lakshmi Narasimhan] * fdd5bdc9 - [vxlanmgr]: Add disabling of fdb learning for linux vxlan interfaces (sonic-net#3205) (3 days ago) [yfedoriachenko] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed issue, which caused make fails with newer docker distributions
- How I did it
Docker version is extracted as 3rd value in "server version" string. But in my docker the 3d value is "version:" not 19.03.0. So I changed the code to return last value in the string.
- How to verify it
Try to use the build system with docker version 19.03
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)