[submodule update] Add SSD Health tools #3218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
andriymoroz-mlnx
force-pushed
the
ssdhealth
branch
from
a2c884b
to
a393afc
Compare
andriymoroz-mlnx
changed the title
jleveque
reviewed
Sep 20, 2019
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
jleveque
approved these changes
Sep 26, 2019
jleveque
reviewed
Oct 4, 2019
| @@ -7,4 +7,4 @@ if [ -t 1 ] ; then | |||
| DOCKER_EXEC_FLAGS+="t" | |||
| fi | |||
|
|
|||
| docker exec -$DOCKER_EXEC_FLAGS pmon sensors "$@" | |||
| docker exec -$DOCKER_EXEC_FLAGS pmon $(basename $0) "$@" | |||
There was a problem hiding this comment.
@andriymoroz-mlnx: Just wondering if we need this script at all anymore, especially because now you need to pass the binary name to the file. The point of these wrapper scripts is to allow users to run executables which reside inside Docker containers as if they are in the base image. If you think there will still be a need for this, then we can leave it, but I think you might want to consider renaming it pmon_cmd_wrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Moroz c_andriym@mellanox.com
- What I did
Added SSD utilities to the pmon docker to support different SSD vendors
- How I did it
Added/updated necessary files in dockers/docker-platform-monitor
Also updates src/sonic-platform-common submodule
[cc2dac5] Add SSD Health API and generic implementation (#47)
- How to verify it
- Description for the changelog
[+] SSD Health CLI available via "show platform ssdhealth"
- A picture of a cute animal (not mandatory but encouraged)
Draft because needs to be updated with the sub-module pointers update after merging
sonic-net/sonic-utilities#587 and sonic-net/sonic-platform-common#47