Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[innovium]: Initial commit #3243

Merged
merged 1 commit into from
Aug 14, 2019
Merged

[innovium]: Initial commit #3243

merged 1 commit into from
Aug 14, 2019

Conversation

tonytitus
Copy link
Contributor

[build] Add ipmitool
[dockers] Add innovium platform in orchagent + ipmitool in snmp
[platform/innovium] Add innovium platform
[device/celestica] Add x86_64-cel_midstone-r0 device for innovium
[device/delta] Add x86_64-delta_et-c032if-r0 device for innovium
[sonic-slave-stretch] Add texi2html

Signed-off-by: Tony Titus ttitus@innovium.com

- What I did
Added Innovium platform support
- How I did it

- How to verify it
Ran PTF tests for T0, T1 and PTF32 topologies

- Description for the changelog
Add support for Innovium platform with corresponding devices.

- A picture of a cute animal (not mandatory but encouraged)

build_debian.sh Outdated Show resolved Hide resolved
@lguohan
Copy link
Collaborator

lguohan commented Jul 31, 2019

minigraph.xml is not needed.

@tonytitus
Copy link
Contributor Author

minigraph.xml is not needed.

Will remove

@lguohan
Copy link
Collaborator

lguohan commented Jul 31, 2019

can you resolve the conflict?

@tonytitus
Copy link
Contributor Author

can you resolve the conflict?

done

@@ -0,0 +1,65 @@
# name lanes speed index mtu
Ethernet0 249,250,251,252 100000 0 9126
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index match the front panel port number.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you elaborate?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went over the doc. Do you mean index should start from 1 instead of 0?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lguohan - does having Index start at 1 instead of 0 have impact on the platform? We wanted to keep behavior same by matching indexing as if index column wasn't there (default starting at 0)

Copy link
Collaborator

@lguohan lguohan Aug 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this column is used for show user which front panel port number it is. therefore it should match front panel port number. if your box front panel port index starts from 0 then you should use 0. if your box front panel port index start from 1, then you should use 1.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The show interface transceiver eeprom/presence commands are adversely impacted if we switch to 1 base. There seems to be a degree of hardcoding to start at 0 on both ODM and SONiC side. For most folks we worked with, they use Alias column to show front panel mapping / breakout.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which part is hardcoded? you can check other platform is using index starting from 1.

https://github.com/Azure/sonic-buildimage/blob/master/device/dell/x86_64-dell_z9100_c2538-r0/Force10-Z9100-C32/port_config.ini

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@lguohan
Copy link
Collaborator

lguohan commented Aug 14, 2019

can you resolve conflict?

[build] Add ipmitool
[dockers] Add innovium platform in orchagent + ipmitool in snmp
[platform/innovium] Add innovium platform
[device/celestica] Add x86_64-cel_midstone-r0 device for innovium
[device/delta] Add x86_64-delta_et-c032if-r0 device for innovium
[sonic-slave-stretch] Add texi2html

Signed-off-by: Tony Titus ttitus@innovium.com
@tonytitus
Copy link
Contributor Author

can you resolve conflict?

Done

@lguohan lguohan merged commit 91510a7 into sonic-net:master Aug 14, 2019
@yxieca
Copy link
Contributor

yxieca commented Aug 14, 2019

Unable to cherry-pick to 201811 branch cleanly directly. An new PR is needed.

tonytitus added a commit to tonytitus/sonic-buildimage that referenced this pull request Aug 15, 2019
[build] Add ipmitool
[dockers] Add innovium platform in orchagent + ipmitool in snmp
[platform/innovium] Add innovium platform
[device/celestica] Add x86_64-cel_midstone-r0 device for innovium
[device/delta] Add x86_64-delta_et-c032if-r0 device for innovium
[sonic-slave-stretch] Add texi2html

Signed-off-by: Tony Titus ttitus@innovium.com
yxieca pushed a commit that referenced this pull request Aug 16, 2019
[build] Add ipmitool
[dockers] Add innovium platform in orchagent + ipmitool in snmp
[platform/innovium] Add innovium platform
[device/celestica] Add x86_64-cel_midstone-r0 device for innovium
[device/delta] Add x86_64-delta_et-c032if-r0 device for innovium
[sonic-slave-stretch] Add texi2html

Signed-off-by: Tony Titus ttitus@innovium.com
wangshengjun pushed a commit to wangshengjun/sonic-buildimage that referenced this pull request Nov 16, 2020
[build] Add ipmitool
[dockers] Add innovium platform in orchagent + ipmitool in snmp
[platform/innovium] Add innovium platform
[device/celestica] Add x86_64-cel_midstone-r0 device for innovium
[device/delta] Add x86_64-delta_et-c032if-r0 device for innovium
[sonic-slave-stretch] Add texi2html

Signed-off-by: Tony Titus ttitus@innovium.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants