Fix read lm75 thermal sensors issue #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
suggested changes
Aug 6, 2019
| str_len = len(search_str) | ||
| idx=file_str.find(search_str) | ||
| if idx==-1: | ||
| print "bcm sdk is not ready ,retrun 0" | ||
| #print "bcm sdk is not ready ,retrun 0" |
There was a problem hiding this comment.
Is it possible to either remove all of these commented-out print statements, or convert them into logging.debug() or logging.verbose() messages?
Remove not need comment printf. Modify needed printf to debug log
jleveque
approved these changes
Aug 7, 2019
mssonicbld
added a commit
that referenced
this pull request
Sep 17, 2024
…lly (#20159) #### Why I did it src/sonic-swss ``` * 20e8b362 - (HEAD -> master, origin/master, origin/HEAD) [dash] Set CA to PA underlay DIP for static encap (#3286) (5 days ago) [Lawrence Lee] * 60f9dde5 - Add pass pl_sip_encoding to SAI (#3285) (5 days ago) [Lawrence Lee] * 3943093d - [Mellanox] Update headroom calculation algorithm (#3235) (6 days ago) [Stephen Sun] ``` #### How I did it #### How to verify it #### Description for the changelog
aidan-gallagher
pushed a commit
to aidan-gallagher/sonic-buildimage
that referenced
this pull request
Nov 16, 2024
…lly (sonic-net#20159) #### Why I did it src/sonic-swss ``` * 20e8b362 - (HEAD -> master, origin/master, origin/HEAD) [dash] Set CA to PA underlay DIP for static encap (sonic-net#3286) (5 days ago) [Lawrence Lee] * 60f9dde5 - Add pass pl_sip_encoding to SAI (sonic-net#3285) (5 days ago) [Lawrence Lee] * 3943093d - [Mellanox] Update headroom calculation algorithm (sonic-net#3235) (6 days ago) [Stephen Sun] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix read lm75 thermal sensors issue
- How I did it
Fix thermal.py and accton_as7326_monitor.py
- How to verify it
Test by sensors and thermal plan.
sensors
coretemp-isa-0000
Adapter: ISA adapter
Physical id 0: +57.0 C (high = +82.0 C, crit = +104.0 C)
Core 0: +57.0 C (high = +82.0 C, crit = +104.0 C)
Core 1: +57.0 C (high = +82.0 C, crit = +104.0 C)
Core 2: +57.0 C (high = +82.0 C, crit = +104.0 C)
Core 3: +57.0 C (high = +82.0 C, crit = +104.0 C)
lm75-i2c-15-48
Adapter: i2c-1-mux (chan_id 6)
temp1: +47.5 C (high = +80.0 C, hyst = +75.0 C)
lm75-i2c-15-49
Adapter: i2c-1-mux (chan_id 6)
temp1: +41.0 C (high = +80.0 C, hyst = +75.0 C)
lm75-i2c-15-4a
Adapter: i2c-1-mux (chan_id 6)
temp1: +34.0 C (high = +80.0 C, hyst = +75.0 C)
Themral plan:
Test to get lm75_48=57500, lm75_49=48500, lm75_4a=36000, lm_4b=34500, cpu=51000
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)