-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[platform]: Added exceptions handling for BFN syseeprom and psuutil #3342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitaliy Senchyshyn <vsenchyshyn@barefootnetworks.com>
akokhan
approved these changes
Aug 14, 2019
NStetskovych-zz
approved these changes
Aug 14, 2019
lguohan
approved these changes
Aug 15, 2019
wangshengjun
pushed a commit
to wangshengjun/sonic-buildimage
that referenced
this pull request
Nov 16, 2020
…onic-net#3342) Added exceptions handling for BFN psuutil.py and eeprom.py which are raised when syseepromd and psud try to connect to the BFN thrift server which is not up yet. Now the exceptions backtrace is not logged to the syslog. Also psud doesn't exit on system bootup due to uncaught exception. Signed-off-by: Vitaliy Senchyshyn <vsenchyshyn@barefootnetworks.com>
mssonicbld
added a commit
that referenced
this pull request
Jun 25, 2024
…atically (#19333) #### Why I did it src/sonic-utilities ``` * 0e6a55ef - (HEAD -> master, origin/master, origin/HEAD) [fast-reboot] Backup database after syncd/swss stopped (#3342) (20 hours ago) [Stepan Blyshchak] * c51758df - fix: fix show bgp summary output typo (#3375) (25 hours ago) [Chenyang Wang] * cf7bfa29 - Add the definition of `log` in `script decode-syseeprom` (#3383) (4 days ago) [Yutong Zhang] * 9d206af7 - [chassis][mutli-asic][lldp] "show lldp table/neighbors" displays error message in output on multi-asis linecard. (#3358) (5 days ago) [Marty Y. Lok] * 515265a5 - Update TRANSCEIVER_FIRMWARE_INFO table for all targets in sfputil (#3370) (6 days ago) [mihirpat1] * 3df762f1 - [config] no op if Golden Config is invalid (#3367) (7 days ago) [jingwenxie] * 8f715acf - [config]Support single file reload for multiasic (#3349) (7 days ago) [jingwenxie] * 31f5fa8e - Improve load_mingraph to wait eth0 restart before exit (#3365) (7 days ago) [Hua Liu] ``` #### How I did it #### How to verify it #### Description for the changelog
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
…atically (sonic-net#19333) #### Why I did it src/sonic-utilities ``` * 0e6a55ef - (HEAD -> master, origin/master, origin/HEAD) [fast-reboot] Backup database after syncd/swss stopped (sonic-net#3342) (20 hours ago) [Stepan Blyshchak] * c51758df - fix: fix show bgp summary output typo (sonic-net#3375) (25 hours ago) [Chenyang Wang] * cf7bfa29 - Add the definition of `log` in `script decode-syseeprom` (sonic-net#3383) (4 days ago) [Yutong Zhang] * 9d206af7 - [chassis][mutli-asic][lldp] "show lldp table/neighbors" displays error message in output on multi-asis linecard. (sonic-net#3358) (5 days ago) [Marty Y. Lok] * 515265a5 - Update TRANSCEIVER_FIRMWARE_INFO table for all targets in sfputil (sonic-net#3370) (6 days ago) [mihirpat1] * 3df762f1 - [config] no op if Golden Config is invalid (sonic-net#3367) (7 days ago) [jingwenxie] * 8f715acf - [config]Support single file reload for multiasic (sonic-net#3349) (7 days ago) [jingwenxie] * 31f5fa8e - Improve load_mingraph to wait eth0 restart before exit (sonic-net#3365) (7 days ago) [Hua Liu] ``` #### How I did it #### How to verify it #### Description for the changelog
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Aug 1, 2024
…atically (sonic-net#19333) #### Why I did it src/sonic-utilities ``` * 0e6a55ef - (HEAD -> master, origin/master, origin/HEAD) [fast-reboot] Backup database after syncd/swss stopped (sonic-net#3342) (20 hours ago) [Stepan Blyshchak] * c51758df - fix: fix show bgp summary output typo (sonic-net#3375) (25 hours ago) [Chenyang Wang] * cf7bfa29 - Add the definition of `log` in `script decode-syseeprom` (sonic-net#3383) (4 days ago) [Yutong Zhang] * 9d206af7 - [chassis][mutli-asic][lldp] "show lldp table/neighbors" displays error message in output on multi-asis linecard. (sonic-net#3358) (5 days ago) [Marty Y. Lok] * 515265a5 - Update TRANSCEIVER_FIRMWARE_INFO table for all targets in sfputil (sonic-net#3370) (6 days ago) [mihirpat1] * 3df762f1 - [config] no op if Golden Config is invalid (sonic-net#3367) (7 days ago) [jingwenxie] * 8f715acf - [config]Support single file reload for multiasic (sonic-net#3349) (7 days ago) [jingwenxie] * 31f5fa8e - Improve load_mingraph to wait eth0 restart before exit (sonic-net#3365) (7 days ago) [Hua Liu] ``` #### How I did it #### How to verify it #### Description for the changelog
mssonicbld
added a commit
that referenced
this pull request
Aug 3, 2024
…atically (#19806) #### Why I did it src/sonic-utilities ``` * cee3e8e0 - (HEAD -> 202405, origin/202405) Enable show ip bgp on sup and -n all for show ip bgp network (#3417) (4 hours ago) [Changrong Wu] * 26f5d757 - Add the definition of `log` in `script decode-syseeprom` (#3383) (4 hours ago) [Yutong Zhang] * af18c89c - Improve load_mingraph to wait eth0 restart before exit (#3365) (4 hours ago) [Hua Liu] * 73e12564 - [chassis][mutli-asic][lldp] "show lldp table/neighbors" displays error message in output on multi-asis linecard. (#3358) (4 hours ago) [Marty Y. Lok] * 69dab7ac - [pbh]: Fix show PBH counters when cache is partial (#3356) (4 hours ago) [Nazarii Hnydyn] * ae20defd - [fast-reboot] Backup database after syncd/swss stopped (#3342) (4 hours ago) [Stepan Blyshchak] * a9876ee6 - Add Checkpoint and Rollback for Multi ASIC. (#3299) (4 hours ago) [Xincun Li] * 7643ac3c - [DPB]Fixing return code of breakout command on failure (#3357) (4 hours ago) [Sudharsan Dhamal Gopalarathnam] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitaliy Senchyshyn vsenchyshyn@barefootnetworks.com
- What I did
Added exceptions handling for BFN psuutil.py and eeprom.py which are raised when syseepromd and psud try to connect to the BFN thrift server which is not up yet. Now the exceptions backtrace is not logged to the syslog. Also psud doesn't exit on system bootup due to uncaught exception.
- How to verify it
sudo psuutil numpsus
sudo psuutil status
redis-dump -d 6 | python -mjson.tool | grep PSU
show version
sudo decode-syseeprom
redis-dump -d 6 | python -mjson.tool | grep EEPROM