[Fast-Reboot]: FR mode is active only first 3 minutes after start. #3352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
|
Why did you have 12 commits? Can you do a git rebase -i origin/master to get rid of the merge commits? Not that it really matters, do you think 90 seconds would be sufficient? after that LAG would flap anyways. |
|
@yxieca 90 seconds is not sufficient. We should wait until 2 minutes. The merge branch commits you see is a result of merging changes from the master repository to my personal repository. It is not a big problem because anyway I'm going to squish this PR into one commit and also I'm going to edit commit message before merging. |
yxieca
approved these changes
Aug 19, 2019
yxieca
pushed a commit
that referenced
this pull request
Aug 21, 2019
…3352) * Fast reboot mode should be enabled only 3 minutes after restart * Advance sonic-quagga submodule
wangshengjun
pushed a commit
to wangshengjun/sonic-buildimage
that referenced
this pull request
Nov 16, 2020
…onic-net#3352) * Fast reboot mode should be enabled only 3 minutes after restart * Advance sonic-quagga submodule
mssonicbld
added a commit
that referenced
this pull request
Nov 7, 2024
…lly (#20699) #### Why I did it src/sonic-swss ``` * ea3e76f7 - (HEAD -> master, origin/master, origin/HEAD) Use -fsanitize=address instead of -lasan for ASAN linker flags (#3344) (70 minutes ago) [Saikrishna Arcot] * 70ade343 - test_vnet.py refactor (#3352) (2 days ago) [siqbal1986] * 3e7b9b46 - [DASH] Add support for ENI counters (#3266) (2 days ago) [Vivek] ``` #### How I did it #### How to verify it #### Description for the changelog
aidan-gallagher
pushed a commit
to aidan-gallagher/sonic-buildimage
that referenced
this pull request
Nov 16, 2024
…lly (sonic-net#20699) #### Why I did it src/sonic-swss ``` * ea3e76f7 - (HEAD -> master, origin/master, origin/HEAD) Use -fsanitize=address instead of -lasan for ASAN linker flags (sonic-net#3344) (70 minutes ago) [Saikrishna Arcot] * 70ade343 - test_vnet.py refactor (sonic-net#3352) (2 days ago) [siqbal1986] * 3e7b9b46 - [DASH] Add support for ENI counters (sonic-net#3266) (2 days ago) [Vivek] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Limit Fast-Reboot mode by 3 minutes after reboot.
- How I did it
When syncd and quagga are started we set Fast-Reboot mode start iff uptime is less than 3 minutes.
- How to verify it
After fast-reboot wait 5 minutes and restart syncd. You should see that syncd starts in cold boot mode.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)