Add IPv6 Support in TACACS #3395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the addition " __vrfname = strdup(*argv + 4);" for ? |
|
There is a problem in applying the patch. HEAD is now at 8dddbec... fix links |
|
looks like the build is broken. |
renukamanavalan
approved these changes
Aug 30, 2019
yxieca
pushed a commit
that referenced
this pull request
Sep 5, 2019
* Add patch to support IPv6 * Add support for IPv6 * Remove in-correct changes by IPv6 support patch
sridhar-ravindran
pushed a commit
to sridhar-ravindran/sonic-buildimage
that referenced
this pull request
Sep 6, 2019
* Add patch to support IPv6 * Add support for IPv6 * Remove in-correct changes by IPv6 support patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added support in PAM and NSS library to support IPv6 addresses.
- How I did it
It is mainly to change the way the IP address and port number is parsed from the string ip addr: port#.
In current code, they look for the first ‘:’ and anything after that is port number. This does not work for IPv6 as ‘:’ exists in address. SO I changed it to look at the last ‘:’ instead.
- How to verify it
Started tac_plus server which has IPv6 address.
Pulled the tac_plus code from:
https://launchpad.net/ubuntu/+source/tacacs+/4.0.4.27a-3
Started the tac_plus service on server side listening in the default port (49).
Added the configs in DUT.
sudo config tacacs authtype login
sudo config tacacs passkey testing123
sudo config aaa authentication login tacacs+
sudo config tacacs add IPv6 server address
$ show tacacs
TACPLUS global auth_type login
TACPLUS global timeout 5 (default)
TACPLUS global passkey testing123
TACPLUS_SERVER address IPv6 server address
priority 1
tcp_port 49
From an external server, tried logging in to the SONiC device as a test user defined in the tacacs server, was able to login successfully.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)