[first boot] sync file system after moving/copying files #3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
jleveque
approved these changes
Oct 2, 2019
|
retest vsimage please |
yxieca
added a commit
that referenced
this pull request
Oct 2, 2019
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This is a tentative fix for an issue noticed in continuous warm reboot upgrade test. Where the files under /etc/sonic/old_config are all in zero size. There are some tentative evidence pointing the
issue at boot up path. Adding a couple sync after moving/copying file to see how it helps.
- How to verify it
Still running continuous warm reboot upgrade. It might take long time to see result. Meanwhile, I think this change is harmless.