[Mellanox]Correct reboot cause when reboot via power cycle #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 10, 2019 06:36
… rebooted by software.
Also check reboot cause file "reset_sw_reset" which indicates the system was rebooted due to software requesting.
jleveque
approved these changes
Oct 14, 2019
|
@stephenxs: Should this PR also be cherry-picked into the 201811 branch? |
No. On 201811 we don't have this issue. |
|
retest this, please. |
keboliu
approved these changes
Oct 15, 2019
sujinmkang
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore reset_sw_reset which indicates rebooted by software.
- What I did
Correct reboot cause when reboot via power cycle by ignoring reset_sw_reset.
process-reboot-cause has the following logic:
Currently we implement "reboot" command via using power cycle. After a power-cycle reboot the reset_sw_reset contains a "1". Originally chassis reboot-cause handling treats it as a hardware-caused reboot and returns it to process-reboot-cause. In this case, the process-reboot-cause treats it as the reboot cause which is wrong.
To resolve that, just don't return hardware reboot cause on reset_sw_reset.
- How I did it
Don't return hardware reboot cause on reset_sw_reset.
- How to verify it
reboot DUT and then check the reboot cause
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)