[build_debuian]: Fix issue #267 (docker connect failure). #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
reviewed
Mar 3, 2017
| @@ -37,7 +37,6 @@ trap_push clean_sys | |||
| sudo LANG=C chroot $FILESYSTEM_ROOT mount sysfs /sys -t sysfs | |||
|
|
|||
| sudo chroot $FILESYSTEM_ROOT service docker start | |||
| sudo chroot $FILESYSTEM_ROOT docker version | |||
There was a problem hiding this comment.
can you provide explaination?
There was a problem hiding this comment.
Docker version command gets information from docker engine via socket. Service runs docker engine but it doesn't wait until docker engine will be fully initialized. In some cases docker version command was run before docker was fully initialized. Actually we don't need in a build time information that docker version command returns so I just removed execution of this command.
I've run build of sonic-mellanox.bin target for 50 times with this patch and issue wasn't reproduced.
|
can you put this explanation in the commit comment? |
lguohan
approved these changes
Mar 3, 2017
|
done |
|
actually, the commit comment doesn't contain the explanation. |
Kalimuthu-Velappan
pushed a commit
to Kalimuthu-Velappan/sonic-buildimage
that referenced
this pull request
Sep 12, 2019
[fast-reboot]: Use pkill instead of killall
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
dmytroxshevchuk
pushed a commit
to dmytroxshevchuk/sonic-buildimage
that referenced
this pull request
Aug 31, 2020
yxieca
pushed a commit
that referenced
this pull request
May 6, 2023
… automatically (#14945) src/sonic-platform-common * c97af3c - (HEAD -> 202205, origin/202205) Modify sfputil show fwversion to include build version for active/inactive FW version fields (#367) (2 days ago) [mihirpat1] * 7705a20 - Adding electrical for 800G and 100G (#365) (2 days ago) [mihirpat1] * d0038fc - SFF-8472: Fix tx_disable_channel to avoid write to read-only bit (#364) (2 days ago) [mihirpat1] * 518a471 - fix get module hardware minor revision (#361) (2 days ago) [Qingxiao Ren]
mssonicbld
added a commit
that referenced
this pull request
Aug 30, 2023
… automatically (#16332) #### Why I did it src/sonic-platform-common ``` * 05cf5c1 - (HEAD -> 202211, origin/202211) Change Y cable simulator log level from error to warning due to false alarm (11 hours ago) [ShiyanWangMS] * 35ea290 - Update CMIS api's rendering max-duration (#375) (11 hours ago) [rajann] * 33bd498 - Retrieve FW version using CDB command for CMIS transceivers + handle single bank FW versioning (#372) (11 hours ago) [mihirpat1] * 2434362 - Render Media lane and Media assignment options info from Application Code (#368) (11 hours ago) [rajann] * 862674b - Modify sfputil show fwversion to include build version for active/inactive FW version fields (#367) (11 hours ago) [mihirpat1] * 8edfece - Adding electrical for 800G and 100G (#365) (11 hours ago) [mihirpat1] * 8a1debf - SFF-8472: Fix tx_disable_channel to avoid write to read-only bit (#364) (11 hours ago) [mihirpat1] * 223a231 - Update host electrical interface for 2x400G breakout cable (#363) (11 hours ago) [mihirpat1] * baabd8f - fix get module hardware minor revision (#361) (11 hours ago) [Qingxiao Ren] * 2ebabf5 - Prevent VDM dictionary related KeyError when a transceiver module is pulled while a bulk get method is interrogating said module (#360) (11 hours ago) [snider-nokia] * 1498ed6 - [CMIS] Add API to get module power up duration (#354) (11 hours ago) [ChiouRung Haung] * 1cae718 - Modify get_host_lane_assignment_option to return value based on application id (#352) (11 hours ago) [mihirpat1] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker version command gets information from docker engine via socket. Service runs docker engine but it doesn't wait until it will be fully initialized. In some cases docker version command was run before docker engine socket was initialized (it depends on system load). Information returned by docker version command is not needed in compile time so it is removed.