[rsyslog] Add support for IPv6 remote addresses #3754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
approved these changes
Nov 14, 2019
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Add support for IPv6 addresses of remote syslog servers in rsyslog.conf.j2 template
- How I did it
Enclose server address in square brackets.
According to the documentation, IPv6 addresses must be enclosed in square brackets. However, it also states that IPv4 addresses as well as host names will also work if enclosed in square brackets. Thus, in order to avoid unnecessary conditional logic, all syslog server addresses will be enclosed in square brackets in the generated rsyslog.conf file.
- How to verify it
Configure the device to have IPv6 addresses for syslog servers and confirm it works.