Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watchdog-control service to disable watchdog during bootup #3877

Merged
merged 6 commits into from
Dec 13, 2019

Conversation

sujinmkang
Copy link
Collaborator

Disable only if it's applicable and the watchdog is enabled.

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@@ -0,0 +1,10 @@
[Unit]
Description=watchdog control service
After=rc-local.service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is probably make more sense to put this service 'After swss.service'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could go either way. Just depends on how early we feel comfortable disabling it, and whether or not we need to disable it early to prevent unnecessary watchdogs during normal reboot.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only use this service to recover fast/warm reboot so far. After swss is fine in that sense. We could also use this to protect against not able to initiate critical services. I agree that after swss could be an issue for cold reboot on wimpy platforms.

@yxieca
Copy link
Contributor

yxieca commented Dec 12, 2019

Please wait for the sonic-utility PR merged and add submodule head change to this PR so they go in together.

@jleveque
Copy link
Contributor

@sujinmkang: It appears something went wrong with your submodule update, as GitHub is indicating there are conflicts.

@sujinmkang sujinmkang merged commit aea1816 into 201811 Dec 13, 2019
@sujinmkang sujinmkang deleted the sujkang-wd-f-fwboot branch December 13, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants