Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox]platform api support firmware install #3931

Merged
merged 9 commits into from
Jan 29, 2020

Conversation

stephenxs
Copy link
Collaborator

- What I did
support firmware install, including CPLD and BIOS.

- How I did it
CPLD: cpldupdate
BIOS: boot to onie and update BIOS in onie and then boot to SONiC

- How to verify it
try installing CPLD/BIOS via platform api
test-install-sonic-then-update-bios.txt
test-update-cpld-gpio.txt

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@jleveque
Copy link
Contributor

Retest vs please

@jleveque
Copy link
Contributor

Retest vsimage please

srideepDell
srideepDell previously approved these changes Jan 15, 2020
@jleveque
Copy link
Contributor

Retest vsimage please

…taller via using the newly introduced onie_entry
keboliu
keboliu previously approved these changes Jan 19, 2020
@liat-grozovik
Copy link
Collaborator

@srideepDell could you please approve this PR or you have additional feedback?

Copy link
Collaborator

@nazariig nazariig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to improve our flows one #3935 is merged

@stephenxs
Copy link
Collaborator Author

@nazariig the code that take advantage of new grub variable to resolve the sonic_installer broken issue has been merged.

}

# ONIE entry must exist in grub config
find_onie_menuentry()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephenxs Since we are already use onie_entry, we do not need this anymore

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed.

jleveque
jleveque previously approved these changes Jan 22, 2020
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please work through comments from other reviewers.

@stephenxs stephenxs dismissed stale reviews from jleveque and keboliu via c3fa992 January 23, 2020 06:49
@nazariig
Copy link
Collaborator

retest vsimage please

@lguohan lguohan merged commit 33e918f into sonic-net:master Jan 29, 2020
@stephenxs stephenxs deleted the fwupdate branch January 29, 2020 05:57
abdosi pushed a commit that referenced this pull request Feb 24, 2020
support firmware install, including CPLD and BIOS.

CPLD: cpldupdate
BIOS: boot to onie and update BIOS in onie and then boot to SONiC
pphuchar pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Mar 9, 2020
support firmware install, including CPLD and BIOS.

CPLD: cpldupdate
BIOS: boot to onie and update BIOS in onie and then boot to SONiC
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
support firmware install, including CPLD and BIOS.

CPLD: cpldupdate
BIOS: boot to onie and update BIOS in onie and then boot to SONiC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants