Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DellEMC: Platform2.0 API enhancements in DellEMC S6000 and other API changes #3956

Merged
merged 1 commit into from
Jan 24, 2020
Merged

DellEMC: Platform2.0 API enhancements in DellEMC S6000 and other API changes #3956

merged 1 commit into from
Jan 24, 2020

Conversation

ArunSaravananBalachandran
Copy link
Contributor

- What I did

  • Handle Platform2.0 APIs based on platform driver initialization in DellEMC S6000.
  • Fixed _sfp_list, _psu_list , _fan_list initialized to None.
  • Return Appropriate values for Fan Direction in DellEMC platforms.

- How I did it

  • Made changes to return values based on the driver initialization state in DellEMC S6000.
  • Use ChassisBase's init to initialize empty lists for different devices (_sfp_list , _psu_list , _fan_list).

- How to verify it

Wrote a python script to load Chassis class and then call the APIs accordingly.
UT logs - UT_logs.txt
Test Script - platform_test_py.txt

- Description for the changelog

DellEMC: Platform2.0 API enhancements in DellEMC S6000 and other API changes

- A picture of a cute animal (not mandatory but encouraged)

@ArunSaravananBalachandran
Copy link
Contributor Author

ArunSaravananBalachandran commented Dec 31, 2019

This PR needs to be picked for 201911 branch, after PR3740 has been ported to 201911 branch.

@jleveque
Copy link
Contributor

jleveque commented Jan 2, 2020

Retest this please

@ArunSaravananBalachandran
Copy link
Contributor Author

retest mellanox please

@ArunSaravananBalachandran
Copy link
Contributor Author

retest vsimage please

1 similar comment
@lguohan
Copy link
Collaborator

lguohan commented Jan 21, 2020

retest vsimage please

@jleveque
Copy link
Contributor

@ArunSaravananBalachandran: Has #3740 been ported to the 201911 branch? I will wait to merge this until it has, because once this gets merged to master, it will get cherry-picked to 201911 shortly.

@ArunSaravananBalachandran
Copy link
Contributor Author

@ArunSaravananBalachandran: Has #3740 been ported to the 201911 branch? I will wait to merge this until it has, because once this gets merged to master, it will get cherry-picked to 201911 shortly.

@jleveque PR3740 can be directly cherry-picked to 201911 branch.

@jleveque
Copy link
Contributor

@ArunSaravananBalachandran: Thanks for the info. I have added a label to that PR so that it gets cherry-picked into 201911.

@jleveque jleveque merged commit d2dadc9 into sonic-net:master Jan 24, 2020
pphuchar pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Mar 9, 2020
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants