Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libnl]: Debian Packaging libnl version 3.5.0 #3967

Merged

Conversation

tahmed-dev
Copy link
Contributor

- What I did
Package libnl v 3.5.0 into a Debian package

- How I did it
Obtained libnl v3.5.0 from https://github.com/thom311/libnl/
Modified existing package of libnl v3.2.27 to reference version 3.5.0 of lib nl

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@tahmed-dev
Copy link
Contributor Author

retest broadcom please

@jleveque
Copy link
Contributor

jleveque commented Jan 3, 2020

Are there any features/fixes we require which version 3.5.0 provides but version 3.4.0 doesn't? If not, we can download version 3.4.0 from the stretch-backports repository, and we will not need to maintain the package ourselves.

Reference: https://packages.debian.org/stretch-backports/libnl-3-200

wget -O libnl3_$(LIBNL3_VERSION).debian.tar.xz -N "https://sonicstorage.blob.core.windows.net/packages/libnl3_$(LIBNL3_VERSION).debian.tar.xz?sv=2015-04-05&sr=b&sig=upIZ9dp5WEcLqp3ODeWKJXq5pJWCfeT0TIM0bx76wxM%3D&se=2028-06-16T21%3A04%3A44Z&sp=r"
wget -O libnl3_$(LIBNL3_VERSION_BASE).orig.tar.gz -N "https://sonicstorage.blob.core.windows.net/packages/libnl3_$(LIBNL3_VERSION_BASE).orig.tar.gz?sv=2015-04-05&sr=b&sig=0HR%2FrWWL54Vl07bQCEX2MNxAnuGkci4KJqxNuDrv%2BCI%3D&se=2033-09-10T22%3A29%3A11Z&sp=r"
wget -O libnl3_$(LIBNL3_VERSION).dsc -N "https://sonicstorage.blob.core.windows.net/packages/libnl3_$(LIBNL3_VERSION).dsc?sv=2015-04-05&sr=b&sig=oi5kfvuaO%2FPHLdq16LpFGsIqYfEc%2FqYmzagYxDDa%2BV8%3D&se=2033-09-10T22%3A30%3A36Z&sp=r"
wget -O libnl3_$(LIBNL3_VERSION).debian.tar.xz -N "https://sonicstorage.blob.core.windows.net/packages/libnl3_$(LIBNL3_VERSION).debian.tar.xz?sv=2015-04-05&sr=b&sig=zOsJTFgzR5CYqDopVeKLunedng2KUsMwY06fbrunQCk%3D&se=2033-09-10T22%3A31%3A39Z&sp=r"
Copy link
Collaborator

@qiluo-msft qiluo-msft Jan 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://sonicstorage [](start = 52, length = 20)

https://sonicstorage [](start = 52, length = 20)

Do we need to fork a git repo for libnl3 and put any modification in that repo, and build the libnl3 from source code during build SONiC images? #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libnl is still being build from the source here as well. I would vote for having internal repository for .debs to live in since there is no dependency on the package during build time, so why not build it once for good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libnl3_3.5.0-1.debian.tar.xz and libnl3_3.5.0-1.dsc are now in git repository.

@pavel-shirshov
Copy link
Contributor

pavel-shirshov commented Jan 3, 2020

@qiluo-msft We don't need to change anything in libnl3
@jleveque 3.5.0 fixes (at least declared) following issue which bites us sometimes:

@pavel-shirshov
Copy link
Contributor

retest vsimage please

lguohan
lguohan previously approved these changes Jan 3, 2020
@qiluo-msft
Copy link
Collaborator

CodeFlow for GitHub does not download executable files. If you trust this file and would like to run it, please download it yourself through GitHub.

Don't check-in binary file. Suggest replace src/libnl3 with a new submodule to build libnl3.deb.


Refers to: src/libnl3/libnl3_3.5.0-1.debian.tar.xz:1 in 098969e. [](commit_id = 098969e4984f2c97da388b2aa27557819698082a, deletion_comment = False)

@tahmed-dev tahmed-dev force-pushed the taahme/update-libnl-to-v3.5.0 branch from 098969e to 6da0eeb Compare January 6, 2020 20:01
@tahmed-dev
Copy link
Contributor Author

CodeFlow for GitHub does not download executable files. If you trust this file and would like to run it, please download it yourself through GitHub.

Don't check-in binary file. Suggest replace src/libnl3 with a new submodule to build libnl3.deb.

Refers to: src/libnl3/libnl3_3.5.0-1.debian.tar.xz:1 in 098969e. [](commit_id = 098969e, deletion_comment = False)

Removed the compressed file from git repository

@tahmed-dev tahmed-dev merged commit df04809 into sonic-net:master Jan 7, 2020
prsunny pushed a commit that referenced this pull request Feb 3, 2020
Packaging libnl 3.5.0 based off libnl 3.2.27 packaging. libnl contains various bug fixes that are nice to have.

pull-request: #3967
signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
abdosi pushed a commit that referenced this pull request Feb 4, 2020
Packaging libnl 3.5.0 based off libnl 3.2.27 packaging. libnl contains various bug fixes that are nice to have.

pull-request: #3967
signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
pphuchar pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Mar 9, 2020
Packaging libnl 3.5.0 based off libnl 3.2.27 packaging. libnl contains various bug fixes that are nice to have.

pull-request: sonic-net#3967
signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
Packaging libnl 3.5.0 based off libnl 3.2.27 packaging. libnl contains various bug fixes that are nice to have.

pull-request: sonic-net#3967
signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants