Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monit] Change the monitoring period from 120 seconds to 60 seconds. #3974

Merged
merged 5 commits into from
Jan 10, 2020

Conversation

yozhao101
Copy link
Contributor

Signed-off-by: Yong Zhao yozhao@microsoft.com

- What I did

According to our offline discussion, we have decided to change the monitoring period
of Monit from 120 seconds to 60 seconds.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
@yozhao101 yozhao101 requested a review from jleveque January 3, 2020 23:42
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this interval will affect all of our current monitoring intervals. As we previously discussed offline, halving this interval means you also need to double all the existing SONiC monit configurations in this PR.

files/image_config/monit/monitrc Outdated Show resolved Hide resolved
seconds and also at the same time double the interval for existing sonic monit config file in
host.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
@yozhao101 yozhao101 closed this Jan 7, 2020
@yozhao101 yozhao101 deleted the monit_global_config branch January 7, 2020 23:31
@yxieca yxieca restored the monit_global_config branch January 10, 2020 02:01
@yxieca yxieca reopened this Jan 10, 2020
@yxieca
Copy link
Contributor

yxieca commented Jan 10, 2020

retest vsimage please

@lguohan lguohan merged commit aa67921 into master Jan 10, 2020
@yxieca yxieca deleted the monit_global_config branch January 10, 2020 21:40
yxieca pushed a commit that referenced this pull request Jan 11, 2020
…3974)

* [Monit] Change the monitoring period of monit from 120 seconds to 60
seconds and also at the same time double the interval for existing sonic monit config file in
host.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
abdosi pushed a commit that referenced this pull request Jan 21, 2020
…3974)

* [Monit] Change the monitoring period of monit from 120 seconds to 60
seconds and also at the same time double the interval for existing sonic monit config file in
host.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
pphuchar pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Mar 9, 2020
…onic-net#3974)

* [Monit] Change the monitoring period of monit from 120 seconds to 60
seconds and also at the same time double the interval for existing sonic monit config file in
host.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
…onic-net#3974)

* [Monit] Change the monitoring period of monit from 120 seconds to 60
seconds and also at the same time double the interval for existing sonic monit config file in
host.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants