-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to build restapi docker #3993
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build failure due to permission issue. can you investigate? |
Retest broadcom please |
1 similar comment
Retest broadcom please |
lguohan
reviewed
Jan 10, 2020
lguohan
approved these changes
Jan 10, 2020
in another PR, you need to add critical process like this one. https://github.com/Azure/sonic-buildimage/blob/master/dockers/docker-orchagent/critical_processes |
abdosi
pushed a commit
that referenced
this pull request
Jan 21, 2020
prsunny
pushed a commit
that referenced
this pull request
Feb 5, 2020
pphuchar
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Mar 9, 2020
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Make changes to build sonic-restapi docker
https://github.com/Azure/sonic-restapi
- How I did it
Add Dockerfiles
Create submodule sonic-restapi to pull code from sonic-restapi repo
- How to verify it
should see target/docker-sonic-restapi.gz once built
- Description for the changelog
Added supporting files and changes to build sonic-restapi docker
- A picture of a cute animal (not mandatory but encouraged)