Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[MultiDB]except src and dockers : replace redis-cli with sonic-db-cli and use new DBConnector" #4002

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Revert "[MultiDB]except src and dockers : replace redis-cli with sonic-db-cli and use new DBConnector" #4002

merged 1 commit into from
Jan 10, 2020

Conversation

lguohan
Copy link
Collaborator

@lguohan lguohan commented Jan 10, 2020

sonic-db-cli return results is not backward compatible with redis-cli

admin@vlab-01:~$ sonic-db-cli CONFIG_DB hget "SNMP_TRAP_CONFIG|v1TrapDest" DestIp              
None
admin@vlab-01:~$ /usr/bin/redis-cli -n 4 hget "SNMP_TRAP_CONFIG|v1TrapDest" DestIp 
(nil)
admin@vlab-01:~$

Reverts #3928

@lguohan
Revert "[MultiDB]except src and dockers : replace redis-cli with soni…
549c777 
…c-db-cli and use new DBConnector (#3928)"

This reverts commit 0dae59a.
@qiluo-msft
Copy link
Collaborator

Retest vs please

@qiluo-msft
Copy link
Collaborator

@dzhangalibaba please help review. Is there any dependency broken if reverted?

@dzhangalibaba
Copy link
Collaborator

revert is safe, all old API/wrapper are supported without any dependency

@lguohan lguohan merged commit 483a594 into master Jan 10, 2020
@lguohan lguohan deleted the revert-3928-others branch January 10, 2020 16:27
@qiluo-msft qiluo-msft mentioned this pull request Feb 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lguohan @qiluo-msft @dzhangalibaba