[MultiDB] (except ./src and ./dockers dirs): replace redis-cli with sonic-db-cli and use new DBConnector #4035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onic-db-cli and use new DBConnector
lguohan
previously approved these changes
Jan 17, 2020
|
retest vsimage please |
1 similar comment
|
retest vsimage please |
lguohan
previously approved these changes
Jan 21, 2020
|
@qiluo-msft We can start review on this PR now |
qiluo-msft
reviewed
Jan 21, 2020
| @@ -113,7 +113,10 @@ function preStartAction() | |||
| fi | |||
|
|
|||
| echo -n "" > /tmp/snmpagentaddr.yml | |||
| keys=`/usr/bin/redis-cli -n 4 keys "SNMP_AGENT_ADDRESS_CONFIG|*"` | |||
| # we should avoid using 'keys' operation via redis-cli or sonic-db-cli | |||
There was a problem hiding this comment.
add explicit TODO as a marker in the comment.
There was a problem hiding this comment.
updated the TODO marker, it trigger the testing again and you may need to approve it later again.
qiluo-msft
previously approved these changes
Jan 21, 2020
dzhangalibaba
dismissed stale reviews from qiluo-msft and lguohan
via
b04ee64
qiluo-msft
approved these changes
Jan 21, 2020
|
retest baseimage please |
|
retest broadcom please |
|
retest vsimage please |
1 similar comment
|
retest vsimage please |
|
Since the previous commit passed PR checks, the new commit only modifies code comment, we are safe to merge. |
abdosi
pushed a commit
that referenced
this pull request
Feb 4, 2020
…onic-db-cli and use new DBConnector (#4035) * [MultiDB] (except ./src and ./dockers dirs): replace redis-cli with sonic-db-cli and use new DBConnector * update comment for a potential bug * update comment * add TODO maker as review reqirement
pphuchar
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Mar 9, 2020
…onic-db-cli and use new DBConnector (sonic-net#4035) * [MultiDB] (except ./src and ./dockers dirs): replace redis-cli with sonic-db-cli and use new DBConnector * update comment for a potential bug * update comment * add TODO maker as review reqirement
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
…onic-db-cli and use new DBConnector (sonic-net#4035) * [MultiDB] (except ./src and ./dockers dirs): replace redis-cli with sonic-db-cli and use new DBConnector * update comment for a potential bug * update comment * add TODO maker as review reqirement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit made changes in sonic-buildimage module directory except ./dockers/(this is done in another PR) amd ./src/(will do in next PR)
Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com