[Service] Enable/disable container auto-restart based on configuration. #4073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of auto-restart feature from database and then decide whether to enable/disable this feature. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
…ame to event listener. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
name to event listener. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
event listener. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
event listener. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
event listener. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
event listener. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
event listener. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
name to event listener. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
event listener. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
…er bgp and event listener will monitor these critical processes and if one of them exited, the event listener will restart this container based on the configuration flag set in database. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
container name to event listener. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
name to event listener. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
name to event listener. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
name to event listener. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
name to event listener. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
container name to event listener. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
container name as parameter to event listener. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
name as parameter to event listener. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
container name as parameter to event listener. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
jleveque
suggested changes
Jan 28, 2020
jleveque
suggested changes
Jan 28, 2020
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
jleveque
suggested changes
Jan 29, 2020
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
jleveque
suggested changes
Jan 29, 2020
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
jleveque
suggested changes
Jan 30, 2020
jleveque
suggested changes
Jan 30, 2020
…le is not found in config db and container name is not found in the table. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
jleveque
previously approved these changes
Jan 30, 2020
|
Retest vsimage please. |
|
Retest vsimage please |
4 similar comments
|
Retest vsimage please |
|
Retest vsimage please |
|
Retest vsimage please |
|
Retest vsimage please |
file. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
jleveque
approved these changes
Feb 3, 2020
|
Retest vsimage please. |
|
Retest vsimage please |
|
Retest vs please |
|
Retest vsimage please |
1 similar comment
|
Retest vsimage please |
abdosi
pushed a commit
that referenced
this pull request
Feb 14, 2020
pphuchar
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Mar 9, 2020
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Currently we already have the auto-restart features for each docker container. That means if a critical
process exited abnormally or crashed, this event will be captured and then the corresponding
container will be restarted. Right now, we want to add a knob/switch for this feature in all containers such that the developer can dynamically turn on/off it during testing new docker images.
How I did it
We will create a table in the database container. In this table, we store the current state of
auto-restart feature for all containers. Initially, the state of this feature will be enabled.
The event listener will dynamically read the state from database container and then decide whether
restart the container based on it once receive the event showing a critical process exited.
The user can use the existing interface (TBD) to modify this state from enabled to disabled or
vice versa.
How to verify it
I manually created a table in the database container called CONTAINER_FEATURE. In this table, each
container will have its corresponding state row such as the initial state of auto-restart for dhcp_relay is in the 'enabled' status.