[init_cfg.json] Maintain a separate init_cfg.json.j2 template file #4092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this file using the content from sonic_debian_extension.j2. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
jleveque
suggested changes
Feb 1, 2020
jleveque
changed the title
generate init_cfg.json to line 269 in sonic_debian_extension.j2. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
jleveque
suggested changes
Feb 2, 2020
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
stepanblyschak
previously approved these changes
Feb 3, 2020
jleveque
suggested changes
Feb 3, 2020
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
jleveque
approved these changes
Feb 3, 2020
|
Retest vs please |
|
Retest vsimage please. |
|
Retest vsimage please |
|
retest vsimage please |
abdosi
pushed a commit
that referenced
this pull request
Feb 14, 2020
pphuchar
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Mar 9, 2020
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
We created a separate init_cfg.json.j2 file instead of generating it in the sonic_debian_extension.j2. After that, we can put new configuration info into file such as the auto-restart feature of each docker container we introduced recently.
- How I did it
Remove the part of code from sonic_debian_extension.j2 and put it in new file init_cfg.json.j2.
- How to verify it