Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arp_update to refresh neighbor entries from APP_DB #4125

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

prsunny
Copy link
Contributor

@prsunny prsunny commented Feb 7, 2020

- What I did
arp_update to refresh neighbor entries from APP_DB

- How I did it
Modified arp_update script

- How to verify it
syslogs

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lguohan
Copy link
Collaborator

lguohan commented Feb 7, 2020

retest vsimage please

@prsunny
Copy link
Contributor Author

prsunny commented Feb 7, 2020

retest vs please

@prsunny
Copy link
Contributor Author

prsunny commented Feb 7, 2020

retest vsimage please

@prsunny
Copy link
Contributor Author

prsunny commented Feb 7, 2020

retest vs please

@zhenggen-xu
Copy link
Collaborator

In general, if we are facing some scale issue already (e,g, > 1K neighbors), we should change this arp_update scripts to scapy based (like the one here: https://github.com/Azure/sonic-swss/blob/11fe6b520693c31c5e1398274035e103d2977a31/neighsyncd/restore_neighbors.py), it is way too slow here. like arping could take ~0.1 second. ping had 0.2 second timeout. we can easily hit 100s seconds to probe the devices, and totally time could be way more than 300 seconds. In the script should should check the time clock and the sleep should exclude the time spent on the processing. (if already more than 300s, no sleep).

files/scripts/arp_update Show resolved Hide resolved
files/scripts/arp_update Show resolved Hide resolved
@zhenggen-xu
Copy link
Collaborator

Approving this PR with some comments:
1, We should continue to root cause of the netlink lost issue. The changes in this PR could be used to monitor such cases so we can cross check events.
2, Scalability of this arp_update script is concerning, we should address that by raw socket mechanism etc, also make the update interval more accurate regardless the time of the probe process. (check time clock instead of sleep blindly).

@prsunny prsunny merged commit 1a0ce98 into sonic-net:master Feb 13, 2020
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request Feb 26, 2020
pphuchar pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Mar 9, 2020
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants