[docker-lldp] Fix lldpcli issue when description has special characters #4133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
lguohan
approved these changes
Feb 9, 2020
|
retest vs please |
abdosi
pushed a commit
that referenced
this pull request
Feb 14, 2020
…rs (#4133) Before the fix: lldpcli configure ports Ethernet96 lldp portidsubtype local 'Eth1/1' description 50G|sonic1|Eth1/3/2 bash: sonic1: command not found bash: Eth1/3/2: No such file or directory After fix: lldpcli configure ports Ethernet96 lldp portidsubtype local 'Eth1/1' description '50G|sonic1|Eth1/3/2' run successfully. Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
yxieca
pushed a commit
that referenced
this pull request
Feb 14, 2020
…rs (#4133) Before the fix: lldpcli configure ports Ethernet96 lldp portidsubtype local 'Eth1/1' description 50G|sonic1|Eth1/3/2 bash: sonic1: command not found bash: Eth1/3/2: No such file or directory After fix: lldpcli configure ports Ethernet96 lldp portidsubtype local 'Eth1/1' description '50G|sonic1|Eth1/3/2' run successfully. Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
pphuchar
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Mar 9, 2020
…rs (sonic-net#4133) Before the fix: lldpcli configure ports Ethernet96 lldp portidsubtype local 'Eth1/1' description 50G|sonic1|Eth1/3/2 bash: sonic1: command not found bash: Eth1/3/2: No such file or directory After fix: lldpcli configure ports Ethernet96 lldp portidsubtype local 'Eth1/1' description '50G|sonic1|Eth1/3/2' run successfully. Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
…rs (sonic-net#4133) Before the fix: lldpcli configure ports Ethernet96 lldp portidsubtype local 'Eth1/1' description 50G|sonic1|Eth1/3/2 bash: sonic1: command not found bash: Eth1/3/2: No such file or directory After fix: lldpcli configure ports Ethernet96 lldp portidsubtype local 'Eth1/1' description '50G|sonic1|Eth1/3/2' run successfully. Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[docker-lldp] Fix lldpcli issue when description has special characters
Signed-off-by: Zhenggen Xu zxu@linkedin.com
This should be back-ported to 201911 and 201811 branch.
- What I did
Fix lldpcli issue when description has special characters
- How I did it
Quote the description field.
- How to verify it
Before the fix:
lldpcli configure ports Ethernet96 lldp portidsubtype local 'Eth1/1' description 50G|sonic1|Eth1/3/2
bash: sonic1: command not found
bash: Eth1/3/2: No such file or directory
After fix:
lldpcli configure ports Ethernet96 lldp portidsubtype local 'Eth1/1' description '50G|sonic1|Eth1/3/2'
run successfully.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)