[201811][interfaces-config.sh] Force lo interface down #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do we only need this change for 201811 branch? What is the plan for other branches? Never mind, found the answer in the related PR. |
yxieca
approved these changes
Feb 13, 2020
|
Retest broadcom please |
prsunny
approved these changes
Feb 14, 2020
prsunny
approved these changes
Feb 14, 2020
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Feb 9, 2021
Force "lo" interface down in interfaces-config.sh to prevent interface-config.service from failing with the following error: ``` -- The result is failed. systemd[1]: networking.service: Unit entered failed state. systemd[1]: networking.service: Failed with result 'exit-code'. interfaces-config.sh[29232]: Job for networking.service failed because the control process exited with error code. interfaces-config.sh[29232]: See "systemctl status networking.service" and "journalctl -xe" for details. interfaces-config.sh[29232]: ifdown: interface lo not configured interfaces-config.sh[29232]: RTNETLINK answers: File exists interfaces-config.sh[29232]: ifup: failed to bring up lo systemd[1]: interfaces-config.service: Main process exited, code=exited, status=1/FAILURE systemd[1]: Failed to start Update interfaces configuration. -- Subject: Unit interfaces-config.service has failed ``` Failure to bring down the interface will result in a failure to subsequently bring the interface back up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Force "lo" interface down in interfaces-config.sh to prevent interface-config.service from failing with the following error:
Failure to bring down the interface will result in a failure to subsequently bring the interface back up.
- How I did it
Add
--forceflag- How to verify it
Repeatedly test that
systemctl restart interfaces-config.servicedoesn't fail to bring down the lo interface.