Ssd mitigation changes #4214
Merged
Ssd mitigation changes #4214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
reviewed
Mar 5, 2020
|
I have reverted the fstrim changes and 2 minutes delay changes and updated the PR. |
sujinmkang
reviewed
Mar 24, 2020
| @@ -3,4 +3,4 @@ Description=Discard unused blocks | |||
|
|
|||
| [Service] | |||
| Type=oneshot | |||
| ExecStart=/sbin/fstrim -av | |||
| ExecStart=/usr/bin/sonic-fstrim | |||
There was a problem hiding this comment.
can we run sonic-fstrim when it's available?
There was a problem hiding this comment.
Yes, we can. I have changed the permissions in the code base itself and built the image and tested it.
There was a problem hiding this comment.
@rkdevi27 can we make platform_log_ssd_health more generically and run it from fstrim.service? And then we don't need sonic-fstrim any more.
There was a problem hiding this comment.
Sujin,
As suggested, I have changed log_ssd_health as generic.
|
Retest vsimage please |
|
retest vsimage please |
|
Retest vsimage please |
sujinmkang
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
I have added the ssd mitigation changes which collects ssd logs for S6100 with 3IE3 ssd.
This Pull request has dependency on the pull request raised in sonic-utilities branch
sonic-net/sonic-utilities#829
- How I did it
I have added the following changes:
Collect ssd logs before fast-reboot.
Added after removing a sonic image and before installing an image.
Block the fast-reboot for 2 minutes from the time of sonic image installation.
- How to verify it
I have tested the functionality and attaching the logs here.
console_logs.txt
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)