[minigraph.py] Add support for 'OutAcl' keyword and attaching ACLs to VLAN interfaces #4229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jleveque
commented
Mar 6, 2020
jleveque
commented
- Support parsing egress ACLs from minigraph file specified by the "OutAcl" element
- Support attaching ACLs to VLAN interfaces
daall
reviewed
Mar 6, 2020
daall
approved these changes
Mar 13, 2020
|
Retest vsimage please |
2 similar comments
|
Retest vsimage please |
|
Retest vsimage please |
|
Do you mean binding ACL table to VLAN? Binding to router interface (VLAN interface being one type of router interface) seems not supported this moment in orchagent. |
|
@wendani: This PR is a prerequisite; loading the config from the minigraph. Related orchagent PR here: sonic-net/sonic-swss#1218 |
|
Thanks. It comes at the right time |
|
Retest vsimage please |
2 similar comments
|
Retest vsimage please |
|
Retest vsimage please |
rlhui
pushed a commit
that referenced
this pull request
Mar 23, 2020
… VLAN interfaces (#4229) - Support parsing egress ACLs from minigraph file specified by the "OutAcl" element - Support attaching ACLs to VLAN interfaces
yxieca
pushed a commit
that referenced
this pull request
Apr 3, 2020
… VLAN interfaces (#4229) - Support parsing egress ACLs from minigraph file specified by the "OutAcl" element - Support attaching ACLs to VLAN interfaces
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
… VLAN interfaces (sonic-net#4229) - Support parsing egress ACLs from minigraph file specified by the "OutAcl" element - Support attaching ACLs to VLAN interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.