fix Z9100 port index issue #4309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
approved these changes
Mar 23, 2020
jleveque
approved these changes
Mar 23, 2020
|
@aravindmani-1: Should this PR be cherry-picked into 201911? 201811? Both? |
|
@jleveque Can you please cherry-pick it for both branches(201811 & 201911)?. |
|
@aravindmani-1 can you create another PR for 201811 branch? this PR cannot be cherry-picked cleanly to 201811 branch. Thanks! |
|
Hi Ying, From the November branch code, i could see that the get_sfp functions ,API 2.0 functions are not invoked currently from xcvrd. I'll raise the Pull request for 201811 branch when needed. Thanks, |
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed port indexing issue in Z9100 for AP
- How I did it
Used overriding method to fix the port index issue.
- How to verify it
Check sfpshow presence,eeprom and do OIR,verify whether the appropriate port status is getting updated or not.
- Description for the changelog
UT log:z9100_indexing_UT_logs.txt