[config/acl] Get ACL config from DHCP and load it in swss container #432

taoyl-ms · 2017-03-24T02:05:59Z

In DHCP configuration, request ACL service url as a custom option
In update_graph service, fetch acl.json similar with minigraph.xml
When starting swss, set ACL according to /etc/sonic/acl.json

stcheng · 2017-03-24T06:38:18Z

dockers/docker-orchagent/start.sh

+function config_acl {
+    if [ -f "/etc/sonic/acl.json" ]; then
+        mkdir -p /etc/swss/config.d/acl
+        rm -rf /etc/swss/config.d/acl/*


i would prefer to have the acl configuration generation part to be there in config.sh script. we could keep the intermediate acl json files stored here. it doesn't hurt and could be used as references.

as a separate suggestion that we could do it later, i think we could just put the configurations that we need into the config.d folder, copying them from /usr/share/sonic/... folder. in sonic-swss repository, we only have samples there. #Closed

We currently don't have a config.sh for swss docker and I don't see much necessity to add one just for acl. We can split start.sh to config.sh and start.sh later if we added more feature and configuration logic became more complicated. #Closed

agree. #Closed

lguohan · 2017-03-27T21:27:27Z

dockers/docker-orchagent/start.sh

+        rm -rf /etc/swss/config.d/acl/*
+        translate_acl -m /etc/sonic/minigraph.xml -o /etc/swss/config.d/acl /etc/sonic/acl.json
+        for filename in /etc/swss/config.d/acl/*.json; do
+            [ -e "$filename" ] || break


why do we need this line? #ByDesign

If there is no file in /etc/swss/config.d/acl/, items in for loop with be executed once with filename equals to '/etc/swss/config.d/acl/*'. And it will lead to error in swssconfig. #ByDesign

lguohan · 2017-03-27T21:28:43Z

files/dhcp/dhclient.conf

@@ -14,11 +14,12 @@
 option rfc3442-classless-static-routes code 121 = array of unsigned integer 8;
 option snmp-community code 224 = text;
 option minigraph-url code 225 = text;
+option acl-url code 226 = text;


can you update the doc https://github.com/Azure/SONiC/wiki/Configuration-and-Minigraph accordingly #Resolved

Updated. #Resolved

…tainer (#432)" This reverts commit 4546372.

* Revert "[config/acl] Get ACL config from DHCP and load it in swss container (#432)" This reverts commit 4546372.

…onic-net#432) Get ACL config from DHCP and load it in swss container

* [config/acl] Get ACL config from DHCP and load it in swss container (#432) * Temporarily disable DHCP option 226

* Add speed and buffer set test Signed-off-by: Andriy Moroz <c_andriym@mellanox.com> * Add some comments to the test Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>

Including commits in sonic-swss-common repo: b423b9c Add support for hexists call (#432) [Tony Titus] 0982996 Remove extension of tableNameSeparatorMap (#430) [Qi Luo] d16cc76 [build]: add azure pipeline build badge (#429) [lguohan] f2aaf55 Set up CI with Azure Pipelines (#428) [lguohan]

… automatically (#18010) #### Why I did it src/sonic-platform-common ``` * 538ec67 - (HEAD -> master, origin/master, origin/HEAD) Tx/Rx power values should be rounded up to 3 decimal places (#432) (6 hours ago) [mihirpat1] ``` #### How I did it #### How to verify it #### Description for the changelog

… automatically (#18008) #### Why I did it src/sonic-platform-common ``` * 7c2ad66 - (HEAD -> 202311, origin/202311) Tx/Rx power values should be rounded up to 3 decimal places (#432) (4 hours ago) [mihirpat1] ``` #### How I did it #### How to verify it #### Description for the changelog

… automatically (#18036) #### Why I did it src/sonic-platform-common ``` * a64276a - (HEAD -> 202305, origin/202305) Tx/Rx power values should be rounded up to 3 decimal places (#432) (22 hours ago) [mihirpat1] ``` #### How I did it #### How to verify it #### Description for the changelog

…D automatically (#18301) #### Why I did it src/sonic-platform-daemons ``` * 8a5ca2b - (HEAD -> master, origin/master, origin/HEAD) Add deterministic link bring-up feature for SFF compliant modules (#383) (2 days ago) [longhuan-cisco] * a591c8a - [ycabled][build] Fix sonic_ycabled build failure in Bookworm (#432) (2 days ago) [Arun Saravanan Balachandran] ``` #### How I did it #### How to verify it #### Description for the changelog

… automatically (sonic-net#18010) #### Why I did it src/sonic-platform-common ``` * 538ec67 - (HEAD -> master, origin/master, origin/HEAD) Tx/Rx power values should be rounded up to 3 decimal places (sonic-net#432) (6 hours ago) [mihirpat1] ``` #### How I did it #### How to verify it #### Description for the changelog

…D automatically (sonic-net#18301) #### Why I did it src/sonic-platform-daemons ``` * 8a5ca2b - (HEAD -> master, origin/master, origin/HEAD) Add deterministic link bring-up feature for SFF compliant modules (sonic-net#383) (2 days ago) [longhuan-cisco] * a591c8a - [ycabled][build] Fix sonic_ycabled build failure in Bookworm (sonic-net#432) (2 days ago) [Arun Saravanan Balachandran] ``` #### How I did it #### How to verify it #### Description for the changelog

… automatically (sonic-net#18010) #### Why I did it src/sonic-platform-common ``` * 538ec67 - (HEAD -> master, origin/master, origin/HEAD) Tx/Rx power values should be rounded up to 3 decimal places (sonic-net#432) (6 hours ago) [mihirpat1] ``` #### How I did it #### How to verify it #### Description for the changelog

…D automatically (sonic-net#18301) #### Why I did it src/sonic-platform-daemons ``` * 8a5ca2b - (HEAD -> master, origin/master, origin/HEAD) Add deterministic link bring-up feature for SFF compliant modules (sonic-net#383) (2 days ago) [longhuan-cisco] * a591c8a - [ycabled][build] Fix sonic_ycabled build failure in Bookworm (sonic-net#432) (2 days ago) [Arun Saravanan Balachandran] ``` #### How I did it #### How to verify it #### Description for the changelog

…tomatically (#20045) #### Why I did it src/sonic-linux-kernel ``` * b2f73b6 - (HEAD -> master, origin/master, origin/HEAD) include adm1275 config within kconfig for usage on cisco platform (#432) (35 hours ago) [Gregory Boudreau] ``` #### How I did it #### How to verify it #### Description for the changelog

…tomatically (sonic-net#20045) #### Why I did it src/sonic-linux-kernel ``` * b2f73b6 - (HEAD -> master, origin/master, origin/HEAD) include adm1275 config within kconfig for usage on cisco platform (sonic-net#432) (35 hours ago) [Gregory Boudreau] ``` #### How I did it #### How to verify it #### Description for the changelog

[config/acl] Get ACL config from DHCP and load it in swss container

2d108ee

taoyl-ms requested review from lguohan and stcheng March 24, 2017 02:06

stcheng reviewed Mar 24, 2017

View reviewed changes

Fix the case when there is no acl jsons

6a84f05

lguohan reviewed Mar 27, 2017

View reviewed changes

lguohan approved these changes Mar 29, 2017

View reviewed changes

taoyl-ms merged commit 4546372 into sonic-net:master Mar 29, 2017

lguohan added a commit that referenced this pull request Mar 30, 2017

Revert "[config/acl] Get ACL config from DHCP and load it in swss con…

ce6e9ce

…tainer (#432)" This reverts commit 4546372.

lguohan added a commit that referenced this pull request Mar 30, 2017

Revert 432 taoyl/acl dhcp (#457)

94934f7

* Revert "[config/acl] Get ACL config from DHCP and load it in swss container (#432)" This reverts commit 4546372.

taoyl-ms added a commit to taoyl-ms/sonic-buildimage that referenced this pull request Apr 3, 2017

[config/acl] Get ACL config from DHCP and load it in swss container (s…

7659e85

…onic-net#432) Get ACL config from DHCP and load it in swss container

taoyl-ms mentioned this pull request Apr 3, 2017

Re-commit PR #432 (SHA 4546372) #474

Merged

taoyl-ms added a commit that referenced this pull request Apr 3, 2017

Re-commit PR #432 (SHA 4546372) (#474)

8c76556

* [config/acl] Get ACL config from DHCP and load it in swss container (#432) * Temporarily disable DHCP option 226

tonytitus mentioned this pull request Dec 29, 2020

[sonic-swss-common] Update submodule #6317

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[config/acl] Get ACL config from DHCP and load it in swss container #432

[config/acl] Get ACL config from DHCP and load it in swss container #432

taoyl-ms commented Mar 24, 2017

stcheng Mar 24, 2017 •

edited by taoyl-ms

Loading

taoyl-ms Mar 24, 2017 •

edited

Loading

stcheng Mar 24, 2017 •

edited by taoyl-ms

Loading

lguohan Mar 27, 2017 •

edited by taoyl-ms

Loading

taoyl-ms Mar 27, 2017 •

edited

Loading

lguohan Mar 27, 2017 •

edited by taoyl-ms

Loading

taoyl-ms Mar 27, 2017 •

edited

Loading

[config/acl] Get ACL config from DHCP and load it in swss container #432

[config/acl] Get ACL config from DHCP and load it in swss container #432

Conversation

taoyl-ms commented Mar 24, 2017

stcheng Mar 24, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

taoyl-ms Mar 24, 2017 • edited Loading

Choose a reason for hiding this comment

stcheng Mar 24, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

lguohan Mar 27, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

taoyl-ms Mar 27, 2017 • edited Loading

Choose a reason for hiding this comment

lguohan Mar 27, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

taoyl-ms Mar 27, 2017 • edited Loading

Choose a reason for hiding this comment

stcheng Mar 24, 2017 •

edited by taoyl-ms

Loading

taoyl-ms Mar 24, 2017 •

edited

Loading

stcheng Mar 24, 2017 •

edited by taoyl-ms

Loading

lguohan Mar 27, 2017 •

edited by taoyl-ms

Loading

taoyl-ms Mar 27, 2017 •

edited

Loading

lguohan Mar 27, 2017 •

edited by taoyl-ms

Loading

taoyl-ms Mar 27, 2017 •

edited

Loading