Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devices][Mellanox] create sai.xml for MSN3800-D112-C8 #4334

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

mykolaf
Copy link
Collaborator

@mykolaf mykolaf commented Mar 27, 2020

Signed-off-by: Mykola Faryma mykolaf@mellanox.com

- What I did
Create sai.xml for Mellanox-SN3800-D112-C8

sai_xml contains info about port splits, previously it simply linked to the MSN3800 sai xml, which does not have splits. New version describes splits and speeds according to Mellanox-SN3800-D112-C8 SKU.

Practically it can cause port recreation on SAI init.
- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
@lguohan
Copy link
Collaborator

lguohan commented Mar 30, 2020

why change sai_3800?

@mykolaf
Copy link
Collaborator Author

mykolaf commented Mar 31, 2020

@lguohan sai_xml contains info about port splits, previously it simply linked to the MSN3800 sai xml, which does not have splits. New version describes splits and speeds according to Mellanox-SN3800-D112-C8 SKU.

Practically it can cause port recreation on SAI init.

@lguohan lguohan merged commit 7e7777e into sonic-net:master Mar 31, 2020
abdosi pushed a commit that referenced this pull request Apr 2, 2020
sai_xml contains info about port splits, previously it simply linked to the MSN3800 sai xml, which does not have splits. New version describes splits and speeds according to Mellanox-SN3800-D112-C8 SKU.

Practically it can cause port recreation on SAI init.

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
sai_xml contains info about port splits, previously it simply linked to the MSN3800 sai xml, which does not have splits. New version describes splits and speeds according to Mellanox-SN3800-D112-C8 SKU.

Practically it can cause port recreation on SAI init.

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants