Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[procdockerstatsd] Fix CMD field in dB #4335

Merged
merged 1 commit into from
Mar 28, 2020
Merged

[procdockerstatsd] Fix CMD field in dB #4335

merged 1 commit into from
Mar 28, 2020

Conversation

GarrickHe
Copy link
Contributor

  • Fix the CMD for the PROCESSSTATS entries so that
    there is a space between the command name and the
    arguments.

Signed-off-by: Garrick He garrick_he@dell.com

- What I did
Fixed a minor issue in the procdockerstatsd script so there is a space between the command name and arguments in the CMD field for PROCESSSTATS entries

- How I did it
minor script fix

- How to verify it
See UT:
Picked a process with arguments from 'ps -ef'
root 20897 8261 0 Mar23 pts/0 00:03:38 /usr/bin/buffermgrd -l /usr/share/sonic/hwsku/pg_profile_lookup.ini

BEFORE FIX:

admin@sonic:~/procdockerstatd$ redis-cli -n 6 HGETALL "PROCESS_STATS|20897"
 1) "%MEM"
 2) "0.0"
 3) "STIME"
 4) "Mar23"
 5) "CMD"
 6) "/usr/bin/buffermgrd-l/usr/share/sonic/hwsku/pg_profile_lookup.ini"
 7) "TIME"
 8) "00:03:38"
 9) "UID"
10) "0"
11) "%CPU"
12) "0.0"
13) "PPID"
14) "8261"
15) "TT"
16) "pts/0"
admin@sonic:~/procdockerstatd$

AFTER FIX:

admin@sonic:~/procdockerstatd$ redis-cli -n 6 HGETALL "PROCESS_STATS|20897"
 1) "%MEM"
 2) "0.0"
 3) "STIME"
 4) "Mar23"
 5) "CMD"
 6) "/usr/bin/buffermgrd -l /usr/share/sonic/hwsku/pg_profile_lookup.ini"
 7) "TIME"
 8) "00:03:38"
 9) "UID"
10) "0"
11) "%CPU"
12) "0.0"
13) "PPID"
14) "8261"
15) "TT"
16) "pts/0"
admin@sonic:~/procdockerstatd$

- Description for the changelog

* Fix the CMD for the PROCESSSTATS entries so that
  there is a space between the command name and the
  arguments.

Signed-off-by: Garrick He garrick_he@dell.com

- A picture of a cute animal (not mandatory but encouraged)

* Fix the CMD for the PROCESSSTATS entries so that
  there is a space between the command name and the
  arguments.

Signed-off-by: Garrick He <garrick_he@dell.com>
@jleveque
Copy link
Contributor

@GarrickHe: Thanks for this fix!

@lguohan
Copy link
Collaborator

lguohan commented Mar 28, 2020

retest vsimage please

@jleveque jleveque merged commit d095d0b into sonic-net:master Mar 28, 2020
rlhui pushed a commit that referenced this pull request Mar 30, 2020
* Fix the CMD for the PROCESSSTATS entries so that
  there is a space between the command name and the
  arguments.

Signed-off-by: Garrick He <garrick_he@dell.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
* Fix the CMD for the PROCESSSTATS entries so that
  there is a space between the command name and the
  arguments.

Signed-off-by: Garrick He <garrick_he@dell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants