Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-py-swsssdk/snmpagent] update submodule for sonic-py-swsssdk / snmpagent #4421

Merged
merged 3 commits into from
Apr 30, 2020

Conversation

dzhangalibaba
Copy link
Collaborator

@dzhangalibaba dzhangalibaba commented Apr 14, 2020

update multiDB changes in swsssdk, including:

update snmpagent, including:

Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com

@lguohan
Copy link
Collaborator

lguohan commented Apr 14, 2020

can you fix the build break?

@dzhangalibaba
Copy link
Collaborator Author

dzhangalibaba commented Apr 15, 2020

can you fix the build break?

looks it caused by
Revert "Revert "read portchannel name from LAG_NAME_MAP_TABLE in COUNTERS_DB (#51)" (#57)" (#64)

My changes won't affect build.

@jleveque

@lguohan
Copy link
Collaborator

lguohan commented Apr 20, 2020

why not update only your commit?

@dzhangalibaba
Copy link
Collaborator Author

why not update only your commit?

Revert "Revert "read portchannel name from LAG_NAME_MAP_TABLE in COUNTERS_DB (#51)" (#57)" (#64). was in before my changes, but not updated head, it has some dependency on other commits. How can I update my commit without some earlier commits ?

@dzhangalibaba dzhangalibaba changed the title [sonic-py-swsssdk] update submodule for sonic-py-swsssdk [sonic-py-swsssdk/swss/swss-common] update submodule for sonic-py-swsssdk / swss / swss-common Apr 20, 2020
@lguohan
Copy link
Collaborator

lguohan commented Apr 20, 2020

sonic-net/sonic-snmpagent@7632ee8 fix the build break issue.

@dzhangalibaba dzhangalibaba changed the title [sonic-py-swsssdk/swss/swss-common] update submodule for sonic-py-swsssdk / swss / swss-common [sonic-py-swsssdk/snmpagent] update submodule for sonic-py-swsssdk / snmpagent Apr 21, 2020
@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

lguohan
lguohan previously approved these changes Apr 21, 2020
jleveque
jleveque previously approved these changes Apr 21, 2020
@lguohan
Copy link
Collaborator

lguohan commented Apr 21, 2020

retest vsimage please

@lguohan
Copy link
Collaborator

lguohan commented Apr 21, 2020

https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/3415/

looks like there are some snmp cpu failures.

@dzhangalibaba
Copy link
Collaborator Author

https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/3415/

looks like there are some snmp cpu failures.

I did a test on updating the LAG changes in swsssdk and other commits on SNMP only. It also failed. I think the commits for snmp those are not updated submodule has issues. #4459

add mock tables for LAG_NAME_MAP_TABLE in COUNTERS_DB (#114)
Parse quagga output without knowledge about hostname, so robust against hostname changes or mismatch (#124)
Fix quagga/FRR parser on IPv6 BGP sessions (#122)
Fix index nodes in LLDP tables whose access right is not-accessible. (#112)
Implement cbgpPeer2State in CiscoBgp4MIB (#119)

@lguohan
Copy link
Collaborator

lguohan commented Apr 23, 2020

retest vsimage please

@judyjoseph
Copy link
Contributor

May be this would need the updated sonic-swss-common submodule too ?
sonic-net/sonic-swss#885 (comment).
I am updating the sonic-swss and sonic-swss-common via this PR #4465. So will try this again after that is committed.

@judyjoseph
Copy link
Contributor

Meanwhile @dzhangalibaba In this PR Could you again advance the sonic-py-swssdk submodule ? I did the merge namespace changes in SonicV2Connector/SonicDBConfig and I am looking forward to advance the pointer again -- could do it here in this PR itself.

@qiluo-msft
Copy link
Collaborator

retest vsimage please

@zhenggen-xu
Copy link
Collaborator

@dzhangalibaba @judyjoseph What are needed to make 201911 branch work while advancing the snmpagent submodule to take some changes (BGP metrics etc)?

@lguohan
Copy link
Collaborator

lguohan commented Apr 27, 2020

retest vsimage please

1 similar comment
@judyjoseph
Copy link
Contributor

retest vsimage please

@judyjoseph
Copy link
Contributor

@dzhangalibaba vsimage tests are passing now after the swss module updates. I have few more updates in sonic-swsssdk-py module. Shall I add it here ?

@dzhangalibaba
Copy link
Collaborator Author

@dzhangalibaba vsimage tests are passing now after the swss module updates. I have few more updates in sonic-swsssdk-py module. Shall I add it here ?

Namespace support in SonicV2Connector (#63). Want to update this as well ?

@judyjoseph
Copy link
Contributor

@dzhangalibaba vsimage tests are passing now after the swss module updates. I have few more updates in sonic-swsssdk-py module. Shall I add it here ?

Namespace support in SonicV2Connector (#63). Want to update this as well ?

Yes, sure thanks

@dzhangalibaba
Copy link
Collaborator Author

@dzhangalibaba vsimage tests are passing now after the swss module updates. I have few more updates in sonic-swsssdk-py module. Shall I add it here ?

Namespace support in SonicV2Connector (#63). Want to update this as well ?

Yes, sure thanks

OK. will update the head here

@dzhangalibaba dzhangalibaba dismissed stale reviews from jleveque and lguohan via 881d69a April 29, 2020 18:01
@dzhangalibaba
Copy link
Collaborator Author

previous checks passed , now update sonic-py-swsssdk to Namespace support in SonicV2Connector (#63) as Judy's need. @judyjoseph

@dzhangalibaba
Copy link
Collaborator Author

retest broadcom please

@dzhangalibaba
Copy link
Collaborator Author

retest vs please

1 similar comment
@judyjoseph
Copy link
Contributor

retest vs please

@judyjoseph
Copy link
Contributor

retest vs please

@abdosi
Copy link
Contributor

abdosi commented May 5, 2020

sonic-pyswssdk is updated with relevant PR's for 201911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants