[Mellanox] Adjust dynamic minimum fan speed algorithm #4476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest vsimage please |
|
retest broadcom please |
jleveque
approved these changes
Apr 28, 2020
|
@Junchao-Mellanox Please create PR for 201911. There is merge conflict. |
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-buildimage
that referenced
this pull request
Jun 1, 2020
* remove air flow direction from dynamic minimum algorithm * adjust minimum table according to thermal data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
The previous dynamic minimum fan speed is determined by air flow direction, ambient temperature and sensor state. We get air flow direction by comparing fan ambient and port ambient temperature, which is not so reliable during chamber test. The solution is to ignore the air flow direction in this algorithm.
- How I did it
Adjust code for dynamic minimum algorithm, now it doesn't care about the air flow direction. Also adjust unit test cases.
- How to verify it
Manual test, regression test and emulation test. In emulation test, I emulated ambient temperature change and watch the fan speed change.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)