Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Fix 'sensors.conf' mapping for MSN4700 #4511

Merged
merged 2 commits into from
May 7, 2020
Merged

[Mellanox] Fix 'sensors.conf' mapping for MSN4700 #4511

merged 2 commits into from
May 7, 2020

Conversation

shlomibitton
Copy link
Contributor

- Why I did it
Fix 'sensors.conf' mapping for SN4700

- How I did it
Edit the 'sensors.conf'.

- How to verify it
Run 'sensors' command on Mellanox MSN4700 platform.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Shlomi Bitton <shlomibi@mellanox.com>
@shlomibitton
Copy link
Contributor Author

@keboliu @liat-grozovik @nazariig
please review

@lguohan
Copy link
Collaborator

lguohan commented Apr 30, 2020

retest vs please

liat-grozovik
liat-grozovik previously approved these changes May 1, 2020
@liat-grozovik
Copy link
Collaborator

Please dont merge yet. Need to merge first hw mgmt V.7.0000.3034. waiting for PR sonic-net/sonic-linux-kernel#133 to be merged and taken first to sonic-buildimage

@lguohan
Copy link
Collaborator

lguohan commented May 1, 2020

#133 is for 201911 branch, please check.

@liat-grozovik
Copy link
Collaborator

#133 is for 201911 branch, please check.

correct. once the hw mgmt will be in both master and 201911 (different PRs) i will merge this one and will tag it for 201911 as well.
I will handle it. thanks!

label curr1 "PMIC-4 ASIC 0.85V VCORE_T2_3 Rail Curr (out)"
label curr2 "PMIC-4 ASIC 1.8V T2_3 Rail Curr (out)"
chip "tps53679-i2c-*-6a"
label in1 "PMIC-5 PSU 12V Rail (in)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shlomibitton why PSU 12V rail has gone?

@liat-grozovik liat-grozovik merged commit 404ae85 into sonic-net:master May 7, 2020
@abdosi
Copy link
Contributor

abdosi commented May 20, 2020

@liat-grozovik is it ok to cherry-pick in 201911 ?

@liat-grozovik
Copy link
Collaborator

liat-grozovik commented May 21, 2020 via email

abdosi pushed a commit that referenced this pull request May 28, 2020
* [Mellanox] Fix 'sensors.conf' mapping for SN4700

Signed-off-by: Shlomi Bitton <shlomibi@mellanox.com>

* Fix some labels name
@shlomibitton shlomibitton deleted the sn4700_sensors_fix branch October 19, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants